Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Component Styles guide for CLI #19791

Merged
merged 1 commit into from Nov 3, 2017

Conversation

wardbell
Copy link
Contributor

Issue #19510

PR Checklist

Please check if your PR fulfills the following requirements:

@mary-poppins
Copy link

You can preview 0d22125 at https://pr19791-0d22125.ngbuilds.io/.

@mary-poppins
Copy link

You can preview cfd5eaa at https://pr19791-cfd5eaa.ngbuilds.io/.

@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@mary-poppins
Copy link

You can preview 77e3946 at https://pr19791-77e3946.ngbuilds.io/.

@@ -4,7 +4,8 @@
"files": [
"!**/*.d.ts",
"!**/*.js",
"!**/*.native.*"
"!**/*.native.*",
"!**/*.[1].*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC, isn't [1] the same as 1?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe, but we are using that syntax everywhere because sometimes we have more values than 1


<code-example path="component-styles/src/app/hero-app.component.ts" title="src/app/hero-app.component.ts">

<code-example path="component-styles/src/app/hero-app.component.ts" title="src/app/hero-app.component.ts (CSS inline">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(CSS inline --> (CSS inline)

@mary-poppins
Copy link

You can preview 1cf4181 at https://pr19791-1cf4181.ngbuilds.io/.

@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • target label
  • merge label
  • green CI

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Nov 2, 2017
@ocombe ocombe added the action: merge The PR is ready for merge by the caretaker label Nov 3, 2017
@vicb vicb merged commit 567cc26 into angular:master Nov 3, 2017
vicb pushed a commit that referenced this pull request Nov 3, 2017
@wardbell wardbell deleted the clify-component-styles branch November 30, 2017 00:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
No open projects
docs
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

8 participants