docs: Deployment guide for CLI #19839

wardbell · 2017-10-20T22:43:48Z

See Issue # 19510

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

mary-poppins · 2017-10-20T22:56:25Z

You can preview 0306819 at https://pr19839-0306819.ngbuilds.io/.

mary-poppins · 2017-10-21T19:46:30Z

You can preview 97dde14 at https://pr19839-97dde14.ngbuilds.io/.

filipesilva · 2017-10-23T16:11:53Z

aio/content/guide/deployment.md

-
-Notice the `paths` key:
-
+For the simplest deployment, build for development and xcopy the output directory to a web server.


xcopy -> copy

filipesilva · 2017-10-23T16:12:57Z

aio/content/guide/deployment.md


-### Webpack (and AOT)
+The remaining [xcopy deployment steps](#xcopy) are the same as before.


xcopy->copy

filipesilva · 2017-10-23T16:14:17Z

aio/content/guide/deployment.md

-Learn more about tree shaking and dead code elmination in
-<a href="https://medium.com/@Rich_Harris/tree-shaking-versus-dead-code-elimination-d3765df85c80#.15ih9cyvl" title="Tree-shaking and Dead Code Elimination">
-this post</a> by rollup-creator, Rich Harris.
+Building for production (or appending the `--environment=prod` flag) enables _production mode_


--environment=prod -> --target=prod

These two are actually different: https://github.com/angular/angular-cli/wiki/build#build-targets-and-environment-files

I just compared --environment=prod vs --environment=dev and they enable/disable prodMod exactly as I said and expected.

So do --target=production vs --target=development. But the --environment flag is way more intuitive, especially after looking at main.ts

if (environment.production) { enableProdMode(); }

Why should I change from --environment to --target? The wiki page is not helping me understand.

Note that I mention --environment here only to talk about enableProd. I'm not talking about any of the other optimizations that would be enabled by --target=production. So I think this text is correct.

You're right, I misunderstood what was being talked about here.

filipesilva · 2017-10-23T16:15:49Z

aio/content/guide/deployment.md

-Bundlers don't know about the router configuration and won't create separate bundles for lazy loaded modules.
-You have to create these bundles manually.
+The CLI **`ng serve`** command builds, watches, and serves the application from a local development server. 
+Unlike `build`, **it erases the output directory** and serves the build artifacts from memory instead of from files for a faster development experience.


ng build also deletes the directory, it just outputs new files there after.

filipesilva · 2017-10-23T16:16:21Z

aio/content/guide/deployment.md

-automatically recognizes lazy loaded `NgModules` and creates separate bundles for them.
+If you want to preserve the previously generated files, 
+append the `-no-delete-output-path` flag to the `serve` command.
+Note that the `ng serve` does NOT update generated files as you make changes.


You can use ng build --watch to continuously generate files.

mary-poppins · 2017-10-23T21:05:16Z

You can preview fd31ace at https://pr19839-fd31ace.ngbuilds.io/.

Foxandxss · 2017-10-24T12:54:28Z

aio/content/guide/deployment.md

@@ -482,75 +282,65 @@ The list is by no means exhaustive, but should provide you with a good starting
 * [Lite-Server](https://github.com/johnpapa/lite-server): the default dev server installed with the
 [Quickstart repo](https://github.com/angular/quickstart) is pre-configured to fallback to `index.html`.


We will deprecate the quickstart, we shouldn't name it anymore.

mary-poppins · 2017-11-02T13:23:56Z

You can preview d64b1fc at https://pr19839-d64b1fc.ngbuilds.io/.

vicb · 2017-11-02T18:25:32Z

missing:

target label
merge label
green CI

IgorMinar · 2017-11-02T23:58:52Z

@vicb the ci failure is a flake and unrelated to this change.

IgorMinar · 2017-11-03T00:00:31Z

I fixed the labels. @wardbell please always apply "target" and "merge" label when your pr is ready for merge.

Foxandxss · 2017-11-03T00:03:27Z

Yes sorry, I have too many PRs and travis is being flaky all day so I go back and forward restarting them and checking all the statuses.

angular-automatic-lock-bot · 2019-09-12T20:21:04Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

wardbell added comp: docs labels Oct 20, 2017

wardbell self-assigned this Oct 20, 2017

wardbell requested review from Foxandxss and filipesilva October 20, 2017 22:43

googlebot added the cla: yes label Oct 20, 2017

Foxandxss mentioned this pull request Oct 20, 2017

List of updates needed for CLI docs #19510

Closed

24 tasks

wardbell force-pushed the clify-deployment branch from 0306819 to 97dde14 Compare October 21, 2017 19:36

filipesilva suggested changes Oct 23, 2017

View reviewed changes

wardbell force-pushed the clify-deployment branch from 97dde14 to fd31ace Compare October 23, 2017 20:53

Foxandxss approved these changes Oct 24, 2017

View reviewed changes

filipesilva approved these changes Nov 2, 2017

View reviewed changes

docs: Deployment guide for CLI

d64b1fc

Foxandxss force-pushed the clify-deployment branch from fd31ace to d64b1fc Compare November 2, 2017 13:00

Foxandxss added this to the 5.0.x milestone Nov 2, 2017

IgorMinar added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Nov 2, 2017

vicb merged commit 03f080b into angular:master Nov 3, 2017

vicb pushed a commit that referenced this pull request Nov 3, 2017

docs: Deployment guide for CLI (#19839)

a8c786c

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: Deployment guide for CLI #19839

docs: Deployment guide for CLI #19839

wardbell commented Oct 20, 2017

mary-poppins commented Oct 20, 2017

mary-poppins commented Oct 21, 2017

filipesilva Oct 23, 2017

filipesilva Oct 23, 2017

filipesilva Oct 23, 2017

wardbell Oct 23, 2017 •

edited

filipesilva Oct 23, 2017

filipesilva Oct 23, 2017

filipesilva Oct 23, 2017

mary-poppins commented Oct 23, 2017

Foxandxss Oct 24, 2017

mary-poppins commented Nov 2, 2017

vicb commented Nov 2, 2017

IgorMinar commented Nov 2, 2017

IgorMinar commented Nov 3, 2017

Foxandxss commented Nov 3, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019


		Notice the `paths` key:

		For the simplest deployment, build for development and xcopy the output directory to a web server.


		### Webpack (and AOT)
		The remaining [xcopy deployment steps](#xcopy) are the same as before.

		@@ -482,75 +282,65 @@ The list is by no means exhaustive, but should provide you with a good starting
		* [Lite-Server](https://github.com/johnpapa/lite-server): the default dev server installed with the
		[Quickstart repo](https://github.com/angular/quickstart) is pre-configured to fallback to `index.html`.

docs: Deployment guide for CLI #19839

docs: Deployment guide for CLI #19839

Conversation

wardbell commented Oct 20, 2017

PR Checklist

mary-poppins commented Oct 20, 2017

mary-poppins commented Oct 21, 2017

filipesilva Oct 23, 2017

Choose a reason for hiding this comment

filipesilva Oct 23, 2017

Choose a reason for hiding this comment

filipesilva Oct 23, 2017

Choose a reason for hiding this comment

wardbell Oct 23, 2017 • edited

Choose a reason for hiding this comment

filipesilva Oct 23, 2017

Choose a reason for hiding this comment

filipesilva Oct 23, 2017

Choose a reason for hiding this comment

filipesilva Oct 23, 2017

Choose a reason for hiding this comment

mary-poppins commented Oct 23, 2017

Foxandxss Oct 24, 2017

Choose a reason for hiding this comment

mary-poppins commented Nov 2, 2017

vicb commented Nov 2, 2017

IgorMinar commented Nov 2, 2017

IgorMinar commented Nov 3, 2017

Foxandxss commented Nov 3, 2017

angular-automatic-lock-bot bot commented Sep 12, 2019

wardbell Oct 23, 2017 •

edited