Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Npm Packages guide for CLI #19850

Merged
merged 1 commit into from Nov 2, 2017
Merged

Conversation

wardbell
Copy link
Contributor

Issue #19510

PR Checklist

Please check if your PR fulfills the following requirements:

@mary-poppins
Copy link

You can preview b97ce30 at https://pr19850-b97ce30.ngbuilds.io/.


***bootstrap***: [Bootstrap](http://getbootstrap.com/) is a popular HTML and CSS framework for designing responsive web apps.
Some of the samples improve their appearance with *bootstrap*.
**[zone.js](https://github.com/angular/zone.js)**: Angular relies on zone.js to run Angular's change detection processes when native JavaScript operations raise events. Zone.js is an implementation of a [specification](https://gist.github.com/mhevery/63fdcdf7c65886051d55) currently before the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be being a bit pedantic here but Angular dosen't "rely" on zones to handle CD, it uses it by default but that's optional.
Maybe reword it in a way to reflect this point?

@Foxandxss Foxandxss added this to the 5.0.x milestone Nov 2, 2017
@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • target label
  • merge label

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2017
@vicb vicb merged commit a91252a into angular:master Nov 2, 2017
vicb pushed a commit that referenced this pull request Nov 2, 2017
@wardbell wardbell deleted the clify-npm-packages branch December 13, 2017 00:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
No open projects
docs
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

6 participants