Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Dependency Injection guides for CLI #19892

Closed
wants to merge 1 commit into from

Conversation

wardbell
Copy link
Contributor

Issue #19510

PR Checklist

Please check if your PR fulfills the following requirements:

@mary-poppins
Copy link

You can preview a056241 at https://pr19892-a056241.ngbuilds.io/.

@vicb
Copy link
Contributor

vicb commented Nov 2, 2017

missing:

  • target label
  • merge label
  • green CI

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Nov 2, 2017
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for navigation.json changes. the ci is still failing so this can't be merged until that is resolved.

@mary-poppins
Copy link

You can preview 128a27b at https://pr19892-128a27b.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 319ccfb at https://pr19892-319ccfb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 94eb9ce at https://pr19892-94eb9ce.ngbuilds.io/.

@Foxandxss Foxandxss added action: merge The PR is ready for merge by the caretaker and removed state: WIP labels Nov 13, 2017
@jasonaden jasonaden closed this in c031860 Nov 14, 2017
jasonaden pushed a commit that referenced this pull request Nov 14, 2017
@wardbell wardbell deleted the clify-di branch November 16, 2017 06:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
No open projects
docs
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

6 participants