Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compilation with TypeScript 2.5 #19966

Closed
wants to merge 1 commit into from

Conversation

rkirov
Copy link
Contributor

@rkirov rkirov commented Oct 27, 2017

A small number of types need to be adjusted. The changes seem to be
backwards compatible with TS 2.4.

@mary-poppins
Copy link

You can preview e41c598 at https://pr19966-e41c598.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e8fe2cd at https://pr19966-e8fe2cd.ngbuilds.io/.

A small number of types need to be adjusted. The changes seem to be
backwards compatible with TS 2.4.
@rkirov rkirov requested a review from tbosch October 27, 2017 01:30
@mary-poppins
Copy link

You can preview 01060d1 at https://pr19966-01060d1.ngbuilds.io/.

@tbosch tbosch added area: core Issues related to the framework runtime target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Oct 27, 2017
@tbosch
Copy link
Contributor

tbosch commented Oct 27, 2017

The failures in Travis is a flake in AIO.
The failure in Circle is the know problem with the commit message since the last release.

@matsko matsko closed this in 005a78b Oct 31, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants