Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): report errors properly in G3 in certain conditions #20041

Closed
wants to merge 1 commit into from

Conversation

tbosch
Copy link
Contributor

@tbosch tbosch commented Oct 30, 2017

Condition: static analysis error, given:

  • noResolve:true
  • generateCodeForLibraries: false
  • CompilerHost.getSourceFile throws on non existent files

All of these are true in G3.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@tbosch tbosch requested a review from chuckjaz October 30, 2017 23:03
@tbosch tbosch added area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Oct 30, 2017
@tbosch tbosch added this to the v5.0.0 milestone Oct 30, 2017
Condition: static analysis error, given:
- noResolve:true
- generateCodeForLibraries: false
- CompilerHost.getSourceFile throws on non existent files

All of these are true in G3.
@tbosch tbosch modified the milestones: v5.0.0, Merge-queue Oct 31, 2017
@tbosch tbosch added the action: merge The PR is ready for merge by the caretaker label Oct 31, 2017
@mary-poppins
Copy link

You can preview fcf38b7 at https://pr20041-fcf38b7.ngbuilds.io/.

matsko pushed a commit that referenced this pull request Oct 31, 2017
…0041)

Condition: static analysis error, given:
- noResolve:true
- generateCodeForLibraries: false
- CompilerHost.getSourceFile throws on non existent files

All of these are true in G3.
PR Close #20041
@matsko matsko closed this in 54480f7 Oct 31, 2017
@tbosch tbosch deleted the fix_recovery branch November 1, 2017 16:17
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants