Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): fix typo on appHighlight #20143

Closed
wants to merge 1 commit into from
Closed

Conversation

hartraft
Copy link
Contributor

@hartraft hartraft commented Nov 3, 2017

docs: changed "appHightlight" to "appHighlight" in Attribute Directives documentation

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Refer to "appHighlight" instead of "appHightlight"

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

"appHightlight" is mentioned

Issue Number: N/A

What is the new behavior?

"appHighlight" is referred to like the rest of the documentation

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@gkalpak gkalpak added comp: docs target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 3, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 3, 2017

Good catch, @hartraft 😃
Can you please change the commit message to adhere to our commit message guidelines and take care of the CLA?

@hartraft
Copy link
Contributor Author

hartraft commented Nov 3, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 3, 2017
changed "appHightlight" to "appHighlight"
@hartraft hartraft changed the title fix typo on appHighlight docs(aio): fix typo on appHighlight Nov 3, 2017
@trotyl trotyl mentioned this pull request Nov 17, 2017
3 tasks
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 17, 2017
@mhevery mhevery closed this in 365712e Nov 17, 2017
mhevery pushed a commit that referenced this pull request Nov 22, 2017
changed "appHightlight" to "appHighlight"

PR Close #20143
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants