Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): fix not found schema #20347

Closed
wants to merge 1 commit into from
Closed

Conversation

aravindfz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 20338

What is the new behavior?

Documentation refrence will work fine.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@trotyl
Copy link
Contributor

trotyl commented Nov 11, 2017

Could you please change the commit message to docs(aio): fix not found schema? The current one is invalid.

The title itself sounds weird, could it be something like: fix schema.ts file url in link?

@gkalpak
Copy link
Member

gkalpak commented Nov 11, 2017

Thx! Please fix the commit message (to follow our commit message guidelines) as mentioned above and include Fixes #20338 (so that the issue is automatically closed when the PR is merged.

@gkalpak gkalpak added comp: docs action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Nov 11, 2017
@aravindfz aravindfz changed the title (docs) : fix not found schema docs(aio): fix not found schema Nov 11, 2017
@aravindfz
Copy link
Contributor Author

Ok @gkalpak I have updated as you suggested. :)

@aravindfz
Copy link
Contributor Author

I'm still in the learning process. I tried to give a commit message but it fails many times. Can you help me how to run the master branch in my local machine

@gkalpak
Copy link
Member

gkalpak commented Nov 13, 2017

I am not sure what you mean by "give a commit message" and "run the master branch" (but I would very much like to help 😁).
If you are trying to change the commit message (and assuming you have cloned https://github.com/aravindfz/angular to your local machine and checked out the pr-schema branch), you can do the following:

# Amend the commit.
git commit --amend
# ...an editor should open with the current commit message, where you can edit it and save...

# Update the PR.
git push --force-with-lease origin pr-schema

@aravindfz
Copy link
Contributor Author

Ok commit message I got it.
If I want to run the core Angular in my local how to do that? :(

@gkalpak
Copy link
Member

gkalpak commented Nov 13, 2017

If you want to build angular and/or run the tests locally, you can follow the instructions in DEVELOPER.md (but be warned that building on Windows is probably not possible atm).

If you want to build/test/serve the angular.io app locally, you can follow the instructions in aio/README.md (it works on Windows too 😃).

BTW, can you make sure that the fixes #... part is separated by the commit message subject by a new line:

docs(aio): fix not found schema

Fixes #20338

@aravindfz
Copy link
Contributor Author

@gkalpak Done (y) sorry for late though was packed at workplace. Just reached home! :)

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Nov 13, 2017
@gkalpak
Copy link
Member

gkalpak commented Nov 13, 2017

No worries 😃 Thx for following up so quickly 👍
(Marked for merge.)

@jasonaden jasonaden closed this in 3caae94 Nov 14, 2017
jasonaden pushed a commit that referenced this pull request Nov 14, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants