Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(core): fix max line length to pass linting #20441

Closed
wants to merge 1 commit into from
Closed

style(core): fix max line length to pass linting #20441

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Nov 15, 2017

Accidentally introduced in #19920, where other linting errors (unrelated to the PR) prevented proper linting.

@gkalpak
style(core): fix max line length to pass linting
f4458fd 
Accidentally introduced in angular#19920, where other linting errors (unrelated to the
PR) prevented proper linting.
@gkalpak gkalpak added area: core Issues related to the framework runtime action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release type: docs labels Nov 15, 2017
@mary-poppins
Copy link

You can preview f4458fd at https://pr20441-f4458fd.ngbuilds.io/.

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 15, 2017
jasonaden pushed a commit that referenced this pull request Nov 15, 2017
@gkalpak @jasonaden
style(core): fix max line length to pass linting (#20441)
259f6bf 
Accidentally introduced in #19920, where other linting errors (unrelated to the
PR) prevented proper linting.

PR Close #20441
@jasonaden jasonaden closed this in c004d48 Nov 15, 2017
@gkalpak gkalpak deleted the style-core-fix-linting branch November 16, 2017 11:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb approved these changes

@ocombe ocombe ocombe approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gkalpak @mary-poppins @vicb @ocombe @googlebot