ci: Update 1% payload size test #20524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
reviewed
Nov 19, 2017
scripts/ci/payload-size.js
Outdated
| // Get branch and project name from command line arguments | ||
| const limitFile = process.argv[2]; | ||
| const project = process.argv[3]; | ||
| const branch = process.argv[4]; |
There was a problem hiding this comment.
What about const [, , limitFile, project, branch] = process.argv? :)
gkalpak
reviewed
Nov 20, 2017
tinayuangao
force-pushed
the
1percent
branch
from
d8039af
to
6c9733e
Compare
|
question: is there a place where we can see a graph of size vs time out of firebase ? |
|
You can view the graph here: https://angular-payload-size.firebaseapp.com/ |
tinayuangao
force-pushed
the
1percent
branch
from
6e698b9
to
6c2da40
Compare
tinayuangao
force-pushed
the
1percent
branch
from
6c2da40
to
bd8103d
Compare
|
You can preview bd8103d at https://pr20524-bd8103d.ngbuilds.io/. |
mhevery
approved these changes
Nov 21, 2017
|
please add merge and target as needed. |
tinayuangao
added
action: merge
|
@tinayuangao please add the correct target label in the future. in general for docs, bug fixes and infrastructure changes we should always try to cherrypick the commit to the stable branch. |
IgorMinar
added
target: patch
mhevery
pushed a commit
that referenced
this pull request
Nov 22, 2017
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Nov 29, 2017
The scripts were accidentally broken in angular#20524. More specifically, when a limit was exceeded the script would break while trying to log an error message due to a missing `commit` variable. This commit fixes it and also does some minor clean-up (improve docs, use more descriptive variable names, remove dead code, etc).
3 tasks
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Nov 29, 2017
The scripts were accidentally broken in angular#20524. More specifically, when a limit was exceeded the script would break while trying to log an error message due to a missing `commit` variable. This commit fixes it and also does some minor clean-up (improve docs, use more descriptive variable names, remove dead code, etc).
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Dec 1, 2017
The scripts were accidentally broken in angular#20524. More specifically, when a limit was exceeded the script would break while trying to log an error message due to a missing `commit` variable. This commit fixes it and also does some minor clean-up (improve docs, use more descriptive variable names, remove dead code, etc).
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Dec 2, 2017
vicb
pushed a commit
to vicb/angular
that referenced
this pull request
Dec 4, 2017
The scripts were accidentally broken in angular#20524. More specifically, when a limit was exceeded the script would break while trying to log an error message due to a missing `commit` variable. This commit fixes it and also does some minor clean-up (improve docs, use more descriptive variable names, remove dead code, etc).
IgorMinar
pushed a commit
that referenced
this pull request
Dec 4, 2017
The scripts were accidentally broken in #20524. More specifically, when a limit was exceeded the script would break while trying to log an error message due to a missing `commit` variable. This commit fixes it and also does some minor clean-up (improve docs, use more descriptive variable names, remove dead code, etc). PR Close #20683
IgorMinar
pushed a commit
that referenced
this pull request
Dec 4, 2017
The scripts were accidentally broken in #20524. More specifically, when a limit was exceeded the script would break while trying to log an error message due to a missing `commit` variable. This commit fixes it and also does some minor clean-up (improve docs, use more descriptive variable names, remove dead code, etc). PR Close #20683
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current 1% payload size check fetch data from firebase, when the change exceed 1% there's no way to fix/approve it.
What is the new behavior?
Save payload size data locally and when change > 1%, we can update the
payload_limits.logfile to change the payload size limits.Does this PR introduce a breaking change?
Other information