Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update pullapprove #20540

Closed
wants to merge 1 commit into from
Closed

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Nov 20, 2017

PR Type

What kind of change does this PR introduce?

[x] CI related changes

What is the current behavior?

Tobias is still listed on pullapprove but he's not working on Angular anymore

What is the new behavior?

Removed Tobias from the list and promoted secondaries to primary when possible, or @chuckjaz when relevant

Does this PR introduce a breaking change?

[x] No

Other information

We need to talk about promoting more people for pullapprove because some packages don't even have a secondary anymore

.pullapprove.yml Outdated
@@ -284,7 +279,7 @@ groups:
files:
- "packages/benchpress/*"
users:
- tbosch #primary
# needs primary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @alxhub is primary now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corect alxhub is now primary for benchpress.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok nice I'll update it

@vicb
Copy link
Contributor

vicb commented Nov 20, 2017

On a side note I think that pullapprove functionality is now builtin into GH. Could you take a quick look at pros/cons @ocombe ?

@ocombe
Copy link
Contributor Author

ocombe commented Nov 21, 2017

From what I understand based on their very short doc it is pretty similar. The main difference is that github will automatically ask a review from the code owners when the PR touches their code. Pullapprove lets you add whoever you want.
This is a big difference for us, because we add multiple owners per branch as backups (usually Igor & Misko) just in case the primary/secondary owners are not there.
We don't want to ask all of the owners for each PR, only the primary or secondary is fine. That would create a lot of noise for nothing.

@ocombe ocombe removed the request for review from chuckjaz November 21, 2017 14:13
@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 21, 2017
@mhevery mhevery closed this in 7cf5e95 Nov 22, 2017
mhevery pushed a commit that referenced this pull request Nov 22, 2017
wKoza pushed a commit to wKoza/angular that referenced this pull request Dec 2, 2017
@ocombe ocombe deleted the ci/remove-tbosch branch January 19, 2018 09:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants