-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update pullapprove #20540
ci: update pullapprove #20540
Conversation
.pullapprove.yml
Outdated
@@ -284,7 +279,7 @@ groups: | |||
files: | |||
- "packages/benchpress/*" | |||
users: | |||
- tbosch #primary | |||
# needs primary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @alxhub is primary now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corect alxhub is now primary for benchpress
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok nice I'll update it
On a side note I think that pullapprove functionality is now builtin into GH. Could you take a quick look at pros/cons @ocombe ? |
6c4d788
to
004ab33
Compare
From what I understand based on their very short doc it is pretty similar. The main difference is that github will automatically ask a review from the code owners when the PR touches their code. Pullapprove lets you add whoever you want. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tobias is still listed on pullapprove but he's not working on Angular anymore
What is the new behavior?
Removed Tobias from the list and promoted secondaries to primary when possible, or @chuckjaz when relevant
Does this PR introduce a breaking change?
Other information
We need to talk about promoting more people for pullapprove because some packages don't even have a secondary anymore