build(aio): prevent comments in code from leaking into doc-gen code snippets #20607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nippets The new version of dgeni-packages (0.22.1) does a better job of rendering code nodes, which do not include comments. Fixes angular#19751
petebacondarwin
added
comp: aio
action: review
|
You can preview 3fc7c05 at https://pr20607-3fc7c05.ngbuilds.io/. |
gkalpak
approved these changes
Nov 23, 2017
gkalpak
added
action: merge
|
Wot no nits?
…On Thu, 23 Nov 2017, 16:16 George Kalpakas, ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20607 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA9Jxi5RcwzpgyEn6ve6bfgZRru76pbks5s5ZpzgaJpZM4QoxXM>
.
|
|
You hacked around them by putting all the changes in -"0.22.0"
+"0.22.1" |
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Nov 28, 2017
The format of rendered types changed, which caused this e2e test to fail
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Nov 29, 2017
mhevery
pushed a commit
that referenced
this pull request
Nov 30, 2017
mhevery
pushed a commit
that referenced
this pull request
Nov 30, 2017
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Dec 2, 2017
…nippets (angular#20607) The new version of dgeni-packages (0.22.1) does a better job of rendering code nodes, which do not include comments. Fixes angular#19751 PR Close angular#20607
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Dec 2, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of dgeni-packages (0.22.1) does a better job of rendering
code nodes, which do not include comments.
Fixes #19751