-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: component-styles guide explains that inline styles must be in CSS #20701
Conversation
You can preview e59796e at https://pr20701-e59796e.ngbuilds.io/. |
db56f84
to
836acae
Compare
You can preview db56f84 at https://pr20701-db56f84.ngbuilds.io/. |
You can preview 836acae at https://pr20701-836acae.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a couple small things (in one comment).
You can also configure the CLI to default to your preferred CSS pre-processer | ||
as explained in the [CLI documentation](https://github.com/angular/angular-cli/wiki/stories-css-preprocessors). | ||
When generating a component file with `ng generate component`, the CLI emits an empty CSS styles file (`.css`) by default. | ||
You can configure the CLI to default to your preferred CSS pre-processer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: pre-processer --> pre-processor
That made me wonder whether it's hyphenated or not. A quick search showed it not hyphenated. Do you feel one way or another about it @wardbell ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Ready for you again.
Cannot write them in less, sass, or stylus See CLI issue angular/angular-cli#8472
836acae
to
8b92069
Compare
You can preview 8b92069 at https://pr20701-8b92069.ngbuilds.io/. |
@@ -179,7 +179,7 @@ to a component's `@Component` decorator: | |||
<code-tabs> | |||
<code-pane title="src/app/hero-app.component.ts (CSS in file)" path="component-styles/src/app/hero-app.component.1.ts"></code-pane> | |||
<code-pane title="src/app/hero-app.component.css" path="component-styles/src/app/hero-app.component.1.css"></code-pane> | |||
</code-tabs> | |||
</code-tabs> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace 😱
Cannot write them in less, sass, or stylus See CLI issue angular/angular-cli#8472 PR Close #20701
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Cannot write them in less, sass, or stylus
See CLI issue angular/angular-cli#8472
PR Checklist
Please check if your PR fulfills the following requirements: