Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: component-styles guide explains that inline styles must be in CSS #20701

Closed
wants to merge 1 commit into from

Conversation

wardbell
Copy link
Contributor

Cannot write them in less, sass, or stylus
See CLI issue angular/angular-cli#8472

PR Checklist

Please check if your PR fulfills the following requirements:

@mary-poppins
Copy link

You can preview e59796e at https://pr20701-e59796e.ngbuilds.io/.

@wardbell wardbell force-pushed the inline-styles-css-only branch 2 times, most recently from db56f84 to 836acae Compare November 30, 2017 01:52
@mary-poppins
Copy link

You can preview db56f84 at https://pr20701-db56f84.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 836acae at https://pr20701-836acae.ngbuilds.io/.

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a couple small things (in one comment).

You can also configure the CLI to default to your preferred CSS pre-processer
as explained in the [CLI documentation](https://github.com/angular/angular-cli/wiki/stories-css-preprocessors).
When generating a component file with `ng generate component`, the CLI emits an empty CSS styles file (`.css`) by default.
You can configure the CLI to default to your preferred CSS pre-processer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: pre-processer --> pre-processor

That made me wonder whether it's hyphenated or not. A quick search showed it not hyphenated. Do you feel one way or another about it @wardbell ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Ready for you again.

Cannot write them in less, sass, or stylus
See CLI issue angular/angular-cli#8472
@mary-poppins
Copy link

You can preview 8b92069 at https://pr20701-8b92069.ngbuilds.io/.

@@ -179,7 +179,7 @@ to a component's `@Component` decorator:
<code-tabs>
<code-pane title="src/app/hero-app.component.ts (CSS in file)" path="component-styles/src/app/hero-app.component.1.ts"></code-pane>
<code-pane title="src/app/hero-app.component.css" path="component-styles/src/app/hero-app.component.1.css"></code-pane>
</code-tabs>
</code-tabs>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace 😱

@wardbell wardbell added the action: merge The PR is ready for merge by the caretaker label Dec 3, 2017
IgorMinar pushed a commit that referenced this pull request Dec 6, 2017
Cannot write them in less, sass, or stylus
See CLI issue angular/angular-cli#8472

PR Close #20701
@IgorMinar IgorMinar closed this in 5e25d39 Dec 6, 2017
@wardbell wardbell deleted the inline-styles-css-only branch December 13, 2017 00:07
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
No open projects
docs
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

6 participants