Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): update i18n locale data to CLDR v32 #20830

Closed
wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Dec 6, 2017

PR Type

What kind of change does this PR introduce?

[x] Refactor

What is the current behavior?

We are using CLDR 31.0.1

What is the new behavior?

We are now using CLDR v32. List of changes between v31.0.1 and v32: http://cldr.unicode.org/index/downloads/cldr-32

Does this PR introduce a breaking change?

[x] No

@ocombe ocombe added area: i18n action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release feature Issue that requests a new feature labels Dec 6, 2017
@ocombe ocombe requested a review from vicb December 6, 2017 14:38
@mary-poppins
Copy link

You can preview 098fd0f at https://pr20830-098fd0f.ngbuilds.io/.

],
,
[
['𑄢𑄧', '𑄥𑄧', '𑄟𑄧', '𑄝𑄪', '𑄝𑄳𑄢𑄨', '𑄥𑄪', '𑄥𑄧'], ['𑄢𑄧𑄝𑄨', '𑄥𑄧𑄟𑄴', '𑄟𑄧𑄁𑄉𑄧𑄣𑄴', '𑄝𑄪𑄖𑄴', '𑄝𑄳𑄢𑄨𑄥𑄪𑄛𑄴', '𑄥𑄪𑄇𑄴𑄇𑄮𑄢𑄴', '𑄥𑄧𑄚𑄨'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the font used by github doesn't handle those characters, see https://github.com/unicode-cldr/cldr-dates-full/blob/master/main/ccp-IN/ca-gregorian.json

@@ -11,11 +11,14 @@

export default [
'de-AT',
[
['vm.', 'nm.'],
['AM', 'PM'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really ?

@@ -13,7 +13,7 @@ export default [
'de-BE',
[
['vm.', 'nm.'],
['vorm.', 'nachm.'],
['AM', 'PM'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really ?

@@ -24,7 +24,8 @@ export default [
,
[
['1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12'],
['ꖨꕪꖃ ꔞꕮ', 'ꕒꕡꖝꖕ', 'ꕾꖺ', 'ꖢꖕ', 'ꖑꕱ', '6', '7', 'ꗛꔕ', 'ꕢꕌ', 'ꕭꖃ', 'ꔞꘋꕔꕿ ꕸꖃꗏ', 'ꖨꕪꕱ ꗏꕮ'],
['ꖨꕪꖃ', 'ꕒꕡ', 'ꕾꖺ', 'ꖢꖕ', 'ꖑꕱ', 'ꖱꘋ', 'ꖱꕞ', 'ꗛꔕ', 'ꕢꕌ', 'ꕭꖃ', 'ꔞꘋ', 'ꖨꕪꕱ'],
['ꖨꕪꖃ ꔞꕮ', 'ꕒꕡꖝꖕ', 'ꕾꖺ', 'ꖢꖕ', 'ꖑꕱ', 'ꖱꘋ', 'ꖱꕞꔤ', 'ꗛꔕ', 'ꕢꕌ', 'ꕭꖃ', 'ꔞꘋꕔꕿ ꕸꖃꗏ', 'ꖨꕪꕱ ꗏꕮ']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected ?

@vicb vicb added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Dec 6, 2017
@vicb vicb removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 6, 2017
@ocombe ocombe changed the title feat(common): update i18n locale data to CLDR v32 refactor(common): update i18n locale data to CLDR v32 Dec 6, 2017
@mary-poppins
Copy link

You can preview faf36d5 at https://pr20830-faf36d5.ngbuilds.io/.

@ocombe ocombe requested a review from IgorMinar December 6, 2017 18:13
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Dec 7, 2017
jasonaden pushed a commit that referenced this pull request Dec 8, 2017
@jasonaden jasonaden closed this in 3ce3b4d Dec 8, 2017
@ocombe ocombe deleted the feat/update-cldr-32 branch December 11, 2017 14:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes feature Issue that requests a new feature target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants