Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation on query :leave does not apply on lazy-loaded children components #20833

Open
gc23 opened this issue Dec 6, 2017 · 3 comments
Open
Labels
area: animations freq2: medium P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Milestone

Comments

@gc23
Copy link

gc23 commented Dec 6, 2017

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

query(':leave' animation has no effect on lazy loaded child components. The component simply disappears

Expected behavior

The leave query should take effect on lazy loaded child components. I appears that it was affected by changes made in 5.0.4
In 5.0.3 animation is happening, however with some sort of a slight delay

Minimal reproduction of the problem with instructions

https://embed.plnkr.co/Nfj70L0RzFnAT8e4eC2I/
Animation on routing is in place. Notice that the lazyloaded components animation is not triggering onLeave

What is the motivation / use case for changing the behavior?

Environment

5.0.4


Angular version: X.Y.Z


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@matsko
Copy link
Contributor

matsko commented Dec 7, 2017

@gc23 I can see the issue. Looking into it. Thank you.

@ArnisLupiks
Copy link

@matsko is there any update on it?

@ngbot ngbot bot modified the milestones: Backlog, needsTriage Feb 26, 2018
@gc23
Copy link
Author

gc23 commented Mar 22, 2018

This is still an issue on 6.0.0-rc.0

stackblitz provided:
https://stackblitz.com/edit/angular-g35ivq

@jelbourn jelbourn added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed severity3: broken labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: animations freq2: medium P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix
Projects
None yet
Development

No branches or pull requests

5 participants