-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(forms): make Validators.email support optional controls #20869
Conversation
bbb85e3
to
2a5682a
Compare
Bring email validator in line with other validators so that empty values are ignored.
2a5682a
to
c1a5e05
Compare
Someone please merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…20869) Bring email validator in line with other validators so that empty values are ignored. PR Close angular#20869
…20869) Bring email validator in line with other validators so that empty values are ignored. PR Close angular#20869
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
Don't appear to be any docs in need of updating.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Empty inputs with the email validator are invalid.
Issue Number: #16183
What is the new behavior?
Empty inputs with the email validator are valid unless they also have the required validator.
Does this PR introduce a breaking change?
Applications will continue to work with this change, however any applications that relied on the email validator treating empty as invalid will need to be updated to also include the required validator.
Other information
#16276 and #16902 have been sitting unmerged for months - I've included changes from both in order to try to get this bug fix in.