Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tour of Heroes HTTP part missing httpOptions #20904

Closed
codeninja55 opened this issue Dec 9, 2017 · 3 comments
Closed

Tour of Heroes HTTP part missing httpOptions #20904

codeninja55 opened this issue Dec 9, 2017 · 3 comments
Assignees
Labels
effort1: hours feature Issue that requests a new feature freq3: high state: community Someone from the Angular community is working on this issue or submitted this PR state: has PR
Milestone

Comments

@codeninja55
Copy link

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

During the HTTP section of the Tour of Heroes, there is no clear instructions on where to store the httpOptions constant.

Expected behavior

Instructions under Heroes and HTTP subsection describing where to define the httpOptions constant.

@ngbot ngbot bot added this to the needsTriage milestone Feb 26, 2018
@jenniferfell jenniferfell added feature Issue that requests a new feature subtype: docs-clarification labels Jun 6, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 6, 2018
@jenniferfell jenniferfell added state: has PR state: community Someone from the Angular community is working on this issue or submitted this PR labels Jun 6, 2018
@jenniferfell
Copy link
Contributor

@chembu : Will you review this issue and associated PR? If the PR looks good, let me know and I'll reach out and seek pull approval. Thanks!

@sreevani-ship-it
Copy link
Contributor

Reviewed the PR. LGTM.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort1: hours feature Issue that requests a new feature freq3: high state: community Someone from the Angular community is working on this issue or submitted this PR state: has PR
Projects
None yet
Development

No branches or pull requests

4 participants