Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(compiler): document the $any type cast function #20968

Closed
wants to merge 1 commit into from

Conversation

chuckjaz
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[x] Documentation content changes

What is the current behavior?

The $any type cast function is not documented.

What is the new behavior?

The $any type cast function is documented.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@mary-poppins
Copy link

You can preview 34de67c at https://pr20968-34de67c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a690ebb at https://pr20968-a690ebb.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 66b2dd5 at https://pr20968-66b2dd5.ngbuilds.io/.

@jasonaden jasonaden added the area: core Issues related to the framework runtime label Dec 12, 2017
@@ -1983,6 +1983,23 @@ You'll need this template operator when you turn on strict null checks. It's opt

<hr/>

{@a any-type-cast-function}

## The `$any` type cast function ( <span class"syntax"> $any( &lt;expression&gt; ) </span> )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please doc $any(this). ? Not sure if ppl know about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vicb vicb added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews area: core Issues related to the framework runtime and removed area: core Issues related to the framework runtime labels Dec 12, 2017
@vicb
Copy link
Contributor

vicb commented Dec 12, 2017

@chuckjaz could please add the $any(this). ?

Once this is added the technical content LGTM.

@chuckjaz chuckjaz removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 13, 2017
@mary-poppins
Copy link

You can preview a09bc9a at https://pr20968-a09bc9a.ngbuilds.io/.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@chuckjaz chuckjaz added cla: yes action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed cla: no labels Dec 15, 2017
@kapunahelewong
Copy link
Contributor

LGTM

@alxhub alxhub added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: merge The PR is ready for merge by the caretaker labels Dec 15, 2017
@chuckjaz
Copy link
Contributor Author

@vicb As we discussed, I am intentionally not pointing out $any(this).privateField as to not encourage this behavior.

@vicb vicb removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 11, 2018
@mary-poppins
Copy link

@vicb
Copy link
Contributor

vicb commented Jan 11, 2018

LGTM @IgorMinar could you please approve ?

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm going to add @kapunahelewong into the list of approvers for these kinds of PRs.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 11, 2018
@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Jan 12, 2018
@alexeagle alexeagle closed this in 2d44a2a Jan 12, 2018
@alexeagle alexeagle removed the target: major This PR is targeted for the next major release label Jan 12, 2018
alexeagle pushed a commit that referenced this pull request Jan 12, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants