New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(compiler): document the $any type cast function #20968
Conversation
You can preview 34de67c at https://pr20968-34de67c.ngbuilds.io/. |
You can preview a690ebb at https://pr20968-a690ebb.ngbuilds.io/. |
You can preview 66b2dd5 at https://pr20968-66b2dd5.ngbuilds.io/. |
aio/content/guide/template-syntax.md
Outdated
@@ -1983,6 +1983,23 @@ You'll need this template operator when you turn on strict null checks. It's opt | |||
|
|||
<hr/> | |||
|
|||
{@a any-type-cast-function} | |||
|
|||
## The `$any` type cast function ( <span class"syntax"> $any( <expression> ) </span> ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please doc $any(this).
? Not sure if ppl know about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@chuckjaz could please add the Once this is added the technical content LGTM. |
You can preview a09bc9a at https://pr20968-a09bc9a.ngbuilds.io/. |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
LGTM |
@vicb As we discussed, I am intentionally not pointing out |
You can preview 34de67c at https://pr20968-34de67c.ngbuilds.io/. |
LGTM @IgorMinar could you please approve ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'm going to add @kapunahelewong into the list of approvers for these kinds of PRs.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
$any
type cast function is not documented.What is the new behavior?
The
$any
type cast function is documented.Does this PR introduce a breaking change?