Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(common): specify explicit locales dir in package.json #21016

Closed
wants to merge 1 commit into from
Closed

build(common): specify explicit locales dir in package.json #21016

wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Locale file directory is implicit in @angular/common.

What is the new behavior?

Locale file directory is explicit in @angular/common.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Followup from #19474.

@filipesilva filipesilva mentioned this pull request Dec 14, 2017
Closed
3 tasks
@mary-poppins
Copy link

You can preview f5497e5 at https://pr21016-f5497e5.ngbuilds.io/.

@ocombe ocombe requested a review from vicb December 14, 2017 16:27
@ocombe ocombe added area: i18n target: patch This PR is targeted for the next patch release feature Issue that requests a new feature labels Dec 14, 2017
vicb
vicb reviewed Dec 15, 2017
View reviewed changes
packages/common/test/i18n/locale_data_folder.ts Outdated
import {basename, resolve} from 'path';

export function main() {
describe('locale data folder', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we filter test files with *_spec.ts ? (ie is this spec executed at all ?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right you are, my bad. Fixing.

vicb
vicb suggested changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the file to be consistent and make sure the test is executed.

@vicb
Copy link
Contributor

vicb commented Dec 15, 2017

Sound like a build commit to me more than a fix - as this is not fixing anything.
As such is there a real interest in merging in in the patch branch (given tools should support earlier version anyway) ?

@filipesilva filipesilva changed the title fix(common): specify explicit locales dir in package.json build(common): specify explicit locales dir in package.json Dec 18, 2017
@filipesilva filipesilva force-pushed the common-locales branch 2 times, most recently from 0725767 to 589373f Compare December 18, 2017 09:15
@filipesilva
Copy link
Contributor Author

@vicb I don't think it is important to merge to patch, no. In a minor would be fine.

I've changed the commit message and renamed the spec file, but I'm not sure what's going on with the pullapprove check.

@filipesilva
Copy link
Contributor Author

@vicb I'm doing a unit test right now but that's the wrong approach. This sort of stuff is more of an integration test. The only package that seems to have integration tests right now is compiler-cli though.

Should I make a new script for common package integration tests? Or is there another approach you would rather me follow.

@filipesilva
Copy link
Contributor Author

@ocombe also mentioned ./integration/i18n/ as a good place to add a test (via a node script).

vicb
vicb approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates

@filipesilva filipesilva force-pushed the common-locales branch 2 times, most recently from c8a38d1 to 3a71476 Compare January 17, 2018 11:03
@mary-poppins
Copy link

You can preview f5497e5 at https://pr21016-f5497e5.ngbuilds.io/.
You can preview 0725767 at https://pr21016-0725767.ngbuilds.io/.
You can preview 589373f at https://pr21016-589373f.ngbuilds.io/.
You can preview 0553690 at https://pr21016-0553690.ngbuilds.io/.

@mary-poppins
Copy link

You can preview deced02 at https://pr21016-deced02.ngbuilds.io/.

@filipesilva
Copy link
Contributor Author

I followed @ocombe's suggestion to add an integration test instead, @vicb PTAL.

@ocombe
Copy link
Contributor

ocombe commented Jan 18, 2018

Sounds good to me

@vicb vicb added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 18, 2018
@ngbot ngbot bot added this to the Backlog milestone Jan 23, 2018
@ocombe ocombe removed this from the Backlog milestone Jan 23, 2018
@vicb
Copy link
Contributor

vicb commented Jan 25, 2018

@filipesilva remember to add the "merge" label for PRs to be merged !

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Jan 25, 2018
@mhevery
Copy link
Contributor

mhevery commented Jan 26, 2018

http://test/OCL:183314180:BASE:183314216:1516928283330:35ca6a6f

@mhevery mhevery closed this in fac4d8d Jan 26, 2018
@filipesilva
Copy link
Contributor Author

@vicb I cannot add labels in angular/angular :/

@filipesilva filipesilva deleted the common-locales branch January 26, 2018 08:43
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
@filipesilva @jbogarthyde
build(common): specify explicit locales dir in package.json (angular#…
f510b4b 
…21016)

PR Close angular#21016
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@filipesilva @leo6104
build(common): specify explicit locales dir in package.json (angular#…
51c70d9 
…21016)

PR Close angular#21016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vicb vicb vicb approved these changes

@jasonaden jasonaden jasonaden approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: i18n cla: yes feature Issue that requests a new feature target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@filipesilva @mary-poppins @vicb @ocombe @mhevery @jasonaden @googlebot