New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(forms): add text about min() and max() as functions #21110
Conversation
packages/forms/src/validators.ts
Outdated
@@ -75,6 +75,7 @@ const EMAIL_REGEXP = | |||
export class Validators { | |||
/** | |||
* Validator that requires controls to have a value greater than a number. | |||
*`min()` exists only as a function, not as a directive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clarify a bit to add suggested usage? Same for the other one.
... exists only as a validator function, not a directive. e.g.:
control = new FormControl('', Validators.min(3));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kara! I've added this for each.
5d139f7
to
e5cfefc
Compare
@kapunahelewong can you please change the scope in the commit message from "aio" to "forms"? "aio" is just for angular.io application changes and this is a document content change so we should label it by the component it affects ("forms" in this case) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending Igor's requested commit change)
e5cfefc
to
0622ae2
Compare
Commit message changed and rebased. Thank you, @IgorMinar! |
@kapunahelewong did you forget to force push to the upstream branch? I don't see the changed commit message. |
I see. you changed the pull request subject and not the commit message. to change the commit message you have to do the following:
|
0622ae2
to
3e18924
Compare
@IgorMinar Oh! Sorry! I'm with you now. Thank you! :) |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #18830
What is the new behavior?
Adds a comment that
min
andmax
are functions, not directives.Does this PR introduce a breaking change?
Other information