Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(forms): add text about min() and max() as functions #21110

Closed
wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #18830

What is the new behavior?

Adds a comment that min and max are functions, not directives.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@@ -75,6 +75,7 @@ const EMAIL_REGEXP =
export class Validators {
/**
* Validator that requires controls to have a value greater than a number.
*`min()` exists only as a function, not as a directive.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe clarify a bit to add suggested usage? Same for the other one.

... exists only as a validator function, not a directive. e.g.:

control = new FormControl('', Validators.min(3));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kara! I've added this for each.

@IgorMinar
Copy link
Contributor

@kapunahelewong can you please change the scope in the commit message from "aio" to "forms"? "aio" is just for angular.io application changes and this is a document content change so we should label it by the component it affects ("forms" in this case)

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending Igor's requested commit change)

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 22, 2017
@kapunahelewong kapunahelewong changed the title docs(aio): add text about min() and max() as functions docs(forms): add text about min() and max() as functions Dec 23, 2017
@kapunahelewong
Copy link
Contributor Author

Commit message changed and rebased. Thank you, @IgorMinar!

@IgorMinar
Copy link
Contributor

@kapunahelewong did you forget to force push to the upstream branch? I don't see the changed commit message.

@IgorMinar
Copy link
Contributor

I see. you changed the pull request subject and not the commit message.

to change the commit message you have to do the following:

git checkout wong-min-max
git commit --amend
# edit the commit message and save
git push origin wong-min-max --force-with-lease

@kapunahelewong
Copy link
Contributor Author

@IgorMinar Oh! Sorry! I'm with you now. Thank you! :)

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 23, 2017
@IgorMinar IgorMinar closed this in a66cd52 Dec 23, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants