Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntryComponents Not Documented #21257

Closed
spottedmahn opened this issue Jan 2, 2018 · 6 comments
Closed

EntryComponents Not Documented #21257

spottedmahn opened this issue Jan 2, 2018 · 6 comments

Comments

@spottedmahn
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[X] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

entryComponents are not documented on the NgModules page.

Expected behavior

entryComponents should be documented.

What is the motivation / use case for changing the behavior?

What are they? What is their purpose?

@Doehl
Copy link
Contributor

Doehl commented Jan 3, 2018

This would be nice, since entryComponents are used by cdk overlay.

@spottedmahn
Copy link
Author

I did find documentation about them under the FAQs.

Also interesting, googling 'angular.io entrycomponents' doesn't seem to find anything on angular.io.

@kapunahelewong
Copy link
Contributor

Thank you, @spottedmahn and @Doehl. Documentation on entryComponents is forthcoming in 20306. You can see the new file dedicated to entryComponents here. The PR has a few details that still need working out, but maybe this will help with any questions in the meantime.

Let me know if you have any questions.

@kapunahelewong
Copy link
Contributor

Hi @spottedmahn and @Doehl there's a new page dedicated to entryComponents! Entry Components. I'll close this issue, but if you still have outstanding questions, please feel free to let me know. And if you see room for improvement in this new doc, I'm very interested in feedback.

@spottedmahn
Copy link
Author

Awesome, thanks @kapunahelewong

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants