-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add http guide sample and adjust text #21326
Conversation
a3de0fe
to
a53d83f
Compare
6636ebe
to
4912013
Compare
You can preview a3de0fe at https://pr21326-a3de0fe.ngbuilds.io/. |
You can preview 6636ebe at https://pr21326-6636ebe.ngbuilds.io/. |
You can preview 4912013 at https://pr21326-4912013.ngbuilds.io/. |
4912013
to
40f81fe
Compare
You can preview 40f81fe at https://pr21326-40f81fe.ngbuilds.io/. |
07d5302
to
4f8e051
Compare
You can preview 07d5302 at https://pr21326-07d5302.ngbuilds.io/. |
You can preview 4f8e051 at https://pr21326-4f8e051.ngbuilds.io/. |
c4b6725
to
f9c029a
Compare
You can preview c4b6725 at https://pr21326-c4b6725.ngbuilds.io/. |
You can preview f9c029a at https://pr21326-f9c029a.ngbuilds.io/. |
f9c029a
to
edaa027
Compare
You can preview edaa027 at https://pr21326-edaa027.ngbuilds.io/. |
edaa027
to
5c13889
Compare
You can preview 5c13889 at https://pr21326-5c13889.ngbuilds.io/. |
f602f33
to
9c29903
Compare
You can preview f602f33 at https://pr21326-f602f33.ngbuilds.io/. |
You can preview 9c29903 at https://pr21326-9c29903.ngbuilds.io/. |
9c29903
to
12eb0db
Compare
You can preview 12eb0db at https://pr21326-12eb0db.ngbuilds.io/. |
29b1b02
to
7569265
Compare
You can preview 7569265 at https://pr21326-7569265.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get the stackblitz PR #20165 merged first before this lands? otherwise the stackblitz PR will suffer another huge merge conflict.
I'm cool with fitting this in after StackBlitz lands. I anticipated that a bit by preparing the stackblitz.json files for this guide. Sign me up for the conflict resolution when the time comes. |
The merge conflicts on Jan 24 are due to the Stackblitz merge. I will resolve and move to stackblitz at same time. |
7569265
to
35ed0fe
Compare
Merge conflicts created by stackblitz PR resolved. Ready to merge. |
You can preview 35ed0fe at https://pr21326-35ed0fe.ngbuilds.io/. |
35ed0fe
to
4bd2c96
Compare
You can preview 4bd2c96 at https://pr21326-4bd2c96.ngbuilds.io/. |
The CI failure (as of this comment) appears to be a known, reported, unrelated saucelabs flake. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The current Http Guide does not have a working code sample. Worse, the code example for this guide is actually the code sample for the discontinued old HTTP module.
The guide does not reference that sample. Instead, it uses markdown ticks to present extracts from a hypothetical application. These extracts do not conform to style guidelines (e.g, they perform HTTP operations within the components instead of delegating to a service) and In several cases there are minor syntax errors.
What is the new behavior?
Added a working
HttpClient
sample that is Hero themed and loosely based on ToH part 6 (the HTTP lesson).The guide prose is adjusted to incorporate excerpts from the code sample. All substantive points in the original prose are retained.
Does this PR introduce a breaking change?