build(aio): upgrade to 5.2.0-rc.0 #21351

IgorMinar · 2018-01-06T03:12:58Z

No description provided.

mary-poppins · 2018-01-06T04:07:05Z

You can preview e6ec8e8 at https://pr21351-e6ec8e8.ngbuilds.io/.

IgorMinar · 2018-01-06T05:46:27Z

uh oh. it looks like there is a regression in core, post likely in how we handle classes. @mhevery @matsko do you know of any change related to that?

The failing test:
https://github.com/IgorMinar/angular/blob/e6ec8e878b6d088857d8b58e1ab43f6066d43ca6/aio/src/app/embedded/code/code-tabs.component.spec.ts#L77-L85

The failure:

Chrome 64.0.3282 (Mac OS X 10.12.6) CodeTabsComponent (tab labels) should add the `class` to the label element FAILED
        Expected $[0] = 'foo-class ng-star-inserted' to equal 'foo-class'.
        Expected $[1] = 'bar-class ng-star-inserted' to equal 'bar-class'.
            at UserContext.<anonymous> Users/iminar/Dev/angular/aio/src/app/embedded/code/code-tabs.component.spec.ts:84:23)
            at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invoke Users/iminar/Dev/angular/aio/node_modules/zone.js/dist/zone.js:388:1)
            at ProxyZoneSpec.webpackJsonp.../../../../zone.js/dist/proxy.js.ProxyZoneSpec.onInvoke Users/iminar/Dev/angular/aio/node_modules/zone.js/dist/proxy.js:79:1)
            at ZoneDelegate.webpackJsonp.../../../../zone.js/dist/zone.js.ZoneDelegate.invoke Users/iminar/Dev/angular/aio/node_modules/zone.js/dist/zone.js:387:1)

petebacondarwin · 2018-01-08T20:19:16Z

@IgorMinar it looks like the animations library is adding extra class names now: c2b3792

I don't think this is a regression, we just need to relax the expectation, no?

gkalpak

LGTM (as soon as Travis is green)

gkalpak · 2018-01-08T20:27:39Z

aio/scripts/payload.sh

@@ -8,5 +8,5 @@ readonly parentDir=$(dirname $thisDir)
 # Track payload size functions
 source ../scripts/ci/payload-size.sh

-trackPayloadSize "aio" "dist/*.bundle.js" true true "${thisDir}/_payload-limits.json"
+trackPayloadSize "aio" "dist/*.js" true true "${thisDir}/_payload-limits.json"


Should we define limits for non-bundle JS files?

this didn't do what I thought it would do. I'll take the commit out.

I wanted to track the size without imposing any limit.

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

mary-poppins · 2018-01-09T06:32:37Z

You can preview 40f4789 at https://pr21351-40f4789.ngbuilds.io/.

IgorMinar · 2018-01-09T07:44:57Z

@gkalpak any idea why I'm getting this error:

Request to overwrite existing public directory: /var/www/aio-builds/21351/40f4789
HTTP_CODE: 409
Running PWA audit for 'https://pr21351-40f4789.ngbuilds.io'...
{ Error: connect ECONNREFUSED 127.0.0.1:41437
    at Object._errnoException (util.js:1024:11)
    at _exceptionWithHostPort (util.js:1046:20)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)
  code: 'ECONNREFUSED',
  errno: 'ECONNREFUSED',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 41437 }
error Command failed with exit code 1.

https://travis-ci.org/angular/angular/jobs/326687199#L1212

IgorMinar · 2018-01-09T07:46:18Z

hmm.. it seems that other of my PRs are failing with a similar error:

Running PWA audit for 'https://pr21350-f0762aa.ngbuilds.io'...
{ Error: connect ECONNREFUSED 127.0.0.1:35845

from https://travis-ci.org/angular/angular/jobs/326686272#L1216 and #21350

gkalpak · 2018-01-09T14:26:41Z

I suspect it is because of https://blog.travis-ci.com/2018-01-08-travis-response-meltdown-spectre.
They are in the process of routing jobs back to the container based infrastructure (which should fix the issue, I hope).

Related Travis issues: travis-ci/travis-ci#9024 and travis-ci/travis-ci#8836 (comment)

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

mary-poppins · 2018-01-10T06:21:03Z

You can preview 5c4336b at https://pr21351-5c4336b.ngbuilds.io/.

mary-poppins · 2018-01-10T06:30:05Z

You can preview 64c1adb at https://pr21351-64c1adb.ngbuilds.io/.

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

mary-poppins · 2018-01-10T07:53:08Z

You can preview d5c87e7 at https://pr21351-d5c87e7.ngbuilds.io/.

IgorMinar · 2018-01-10T17:14:24Z

@filipesilva please take a look at

build(aio): upgrade to 5.2.0-rc.0 #21351 (comment) (report)
https://pr21351-e62d89d.ngbuilds.io/ (repro)
ea97625 (fix)

mary-poppins · 2018-01-10T17:16:35Z

You can preview ea97625 at https://pr21351-ea97625.ngbuilds.io/.

filipesilva · 2018-01-10T17:23:39Z

I understand the context now. I do not know what is problem is, no... Can someone setup a repro and issue on https://github.com/angular/devkit?

filipesilva · 2018-01-10T17:35:59Z

I tried a naive repro on a new app, using Angular 5.1.3 and CLI 1.6.3, with a ng serve --prod:

// main.ts
import { Observable } from 'rxjs/Observable';
import 'rxjs/add/observable/timer';
console.log(Observable.timer);

The console.log printed a function.

Then I updated to Angular 5.2.0 and the result was the same.

Not sure why it's different on AIO.

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

-rw-r--r-- 1 iminar eng 72498 Jan 9 22:20 dist/0.0d2802b63e9f4f4615cd.chunk.js -rw-r--r-- 1 iminar eng 14872 Jan 9 22:20 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1558 Jan 9 22:20 dist/inline.cb4b7a639193fc489d3b.bundle.js -rw-r--r-- 1 iminar eng 454654 Jan 9 22:20 dist/main.b65f32ffc92e075e64e0.bundle.js -rw-r--r-- 1 iminar eng 40264 Jan 9 22:20 dist/polyfills.87edf5d695f14a29bf91.bundle.js -rw-r--r-- 1 iminar eng 54001 Jan 9 22:20 dist/worker-basic.min.js

…nd tracking easier

mary-poppins · 2018-01-10T21:48:31Z

You can preview 4d022ce at https://pr21351-4d022ce.ngbuilds.io/.

Because of c2b3792 one of the test assertions had to be adjusted (more info: #21351 (comment)). PR Close #21351

PR Close #21351

-rw-r--r-- 1 iminar eng 72498 Jan 9 22:20 dist/0.0d2802b63e9f4f4615cd.chunk.js -rw-r--r-- 1 iminar eng 14872 Jan 9 22:20 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1558 Jan 9 22:20 dist/inline.cb4b7a639193fc489d3b.bundle.js -rw-r--r-- 1 iminar eng 454654 Jan 9 22:20 dist/main.b65f32ffc92e075e64e0.bundle.js -rw-r--r-- 1 iminar eng 40264 Jan 9 22:20 dist/polyfills.87edf5d695f14a29bf91.bundle.js -rw-r--r-- 1 iminar eng 54001 Jan 9 22:20 dist/worker-basic.min.js PR Close #21351

…nd tracking easier (#21351) PR Close #21351

PR Close #21351

-rw-r--r-- 1 iminar eng 72498 Jan 9 22:20 dist/0.0d2802b63e9f4f4615cd.chunk.js -rw-r--r-- 1 iminar eng 14872 Jan 9 22:20 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1558 Jan 9 22:20 dist/inline.cb4b7a639193fc489d3b.bundle.js -rw-r--r-- 1 iminar eng 454654 Jan 9 22:20 dist/main.b65f32ffc92e075e64e0.bundle.js -rw-r--r-- 1 iminar eng 40264 Jan 9 22:20 dist/polyfills.87edf5d695f14a29bf91.bundle.js -rw-r--r-- 1 iminar eng 54001 Jan 9 22:20 dist/worker-basic.min.js PR Close #21351

…nd tracking easier (#21351) PR Close #21351

PR Close #21351

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)). PR Close angular#21351

PR Close angular#21351

-rw-r--r-- 1 iminar eng 72498 Jan 9 22:20 dist/0.0d2802b63e9f4f4615cd.chunk.js -rw-r--r-- 1 iminar eng 14872 Jan 9 22:20 dist/4.c719ac5645940382cdce.chunk.js -rw-r--r-- 1 iminar eng 1558 Jan 9 22:20 dist/inline.cb4b7a639193fc489d3b.bundle.js -rw-r--r-- 1 iminar eng 454654 Jan 9 22:20 dist/main.b65f32ffc92e075e64e0.bundle.js -rw-r--r-- 1 iminar eng 40264 Jan 9 22:20 dist/polyfills.87edf5d695f14a29bf91.bundle.js -rw-r--r-- 1 iminar eng 54001 Jan 9 22:20 dist/worker-basic.min.js PR Close angular#21351

…nd tracking easier (angular#21351) PR Close angular#21351

PR Close angular#21351

angular-automatic-lock-bot · 2019-09-13T04:20:49Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Jan 6, 2018

IgorMinar changed the title ~~Aio/upgrade to 5.2.0 rc.0~~ aio: upgrade to 5.2.0 rc.0 Jan 6, 2018

IgorMinar changed the title ~~aio: upgrade to 5.2.0 rc.0~~ build(aio): upgrade to 5.2.0-rc.0 Jan 6, 2018

IgorMinar force-pushed the aio/upgrade-to-5.2.0-rc.0 branch from 0c129ae to e6ec8e8 Compare January 6, 2018 04:00

IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 6, 2018

IgorMinar added state: blocked and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 6, 2018

IgorMinar requested review from gkalpak and petebacondarwin January 8, 2018 09:07

kara added the comp: aio label Jan 8, 2018

petebacondarwin added this to WIP in docs-infra Jan 8, 2018

gkalpak approved these changes Jan 8, 2018

View reviewed changes

IgorMinar force-pushed the aio/upgrade-to-5.2.0-rc.0 branch from e6ec8e8 to 40f4789 Compare January 9, 2018 06:23

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Jan 9, 2018

build(aio): upgrade to angular@5.2.0-rc.0

b8657fc

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

IgorMinar force-pushed the aio/upgrade-to-5.2.0-rc.0 branch from 40f4789 to 5c4336b Compare January 10, 2018 06:13

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Jan 10, 2018

build(aio): upgrade to angular@5.2.0-rc.0

4dd455b

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

IgorMinar force-pushed the aio/upgrade-to-5.2.0-rc.0 branch from 64c1adb to d5c87e7 Compare January 10, 2018 07:46

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Jan 10, 2018

build(aio): upgrade to angular@5.2.0-rc.0

bfc0e50

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2018

IgorMinar and others added 5 commits January 10, 2018 12:38

build(aio): upgrade to angular@5.2.0-rc.0

08826e2

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)).

ci(aio): track sizes of all js files

7f71d3d

build(aio): turn on namedChunks option to make debugging, profiling a…

e6ba1d4

…nd tracking easier

fix(aio): preserve static Observable methods

4d022ce

alexeagle force-pushed the aio/upgrade-to-5.2.0-rc.0 branch from ea97625 to 4d022ce Compare January 10, 2018 20:39

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

build(aio): upgrade to angular@5.2.0-rc.0 (#21351)

c4b7192

Because of c2b3792 one of the test assertions had to be adjusted (more info: #21351 (comment)). PR Close #21351

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

ci(aio): track sizes of all js files (#21351)

a0dcb0b

PR Close #21351

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

build(aio): turn on namedChunks option to make debugging, profiling a…

a2432c9

…nd tracking easier (#21351) PR Close #21351

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

fix(aio): preserve static Observable methods (#21351)

7b463df

PR Close #21351

alexeagle closed this in 7c9ba2d Jan 10, 2018

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

ci(aio): track sizes of all js files (#21351)

a0a73fe

PR Close #21351

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

build(aio): turn on namedChunks option to make debugging, profiling a…

85013ad

…nd tracking easier (#21351) PR Close #21351

alexeagle pushed a commit that referenced this pull request Jan 10, 2018

fix(aio): preserve static Observable methods (#21351)

137b9c7

PR Close #21351

petebacondarwin removed this from WIP in docs-infra Jan 11, 2018

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): upgrade to angular@5.2.0-rc.0 (angular#21351)

b0fa6f4

Because of c2b3792 one of the test assertions had to be adjusted (more info: angular#21351 (comment)). PR Close angular#21351

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

ci(aio): track sizes of all js files (angular#21351)

269a5df

PR Close angular#21351

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

build(aio): turn on namedChunks option to make debugging, profiling a…

74fa50d

…nd tracking easier (angular#21351) PR Close angular#21351

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

fix(aio): preserve static Observable methods (angular#21351)

1f152ac

PR Close angular#21351

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(aio): upgrade to 5.2.0-rc.0 #21351

build(aio): upgrade to 5.2.0-rc.0 #21351

IgorMinar commented Jan 6, 2018

mary-poppins commented Jan 6, 2018

IgorMinar commented Jan 6, 2018 •

edited

petebacondarwin commented Jan 8, 2018

gkalpak left a comment

gkalpak Jan 8, 2018

IgorMinar Jan 10, 2018

IgorMinar Jan 10, 2018

mary-poppins commented Jan 9, 2018

IgorMinar commented Jan 9, 2018

IgorMinar commented Jan 9, 2018

gkalpak commented Jan 9, 2018 •

edited

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

IgorMinar commented Jan 10, 2018 •

edited

mary-poppins commented Jan 10, 2018

filipesilva commented Jan 10, 2018

filipesilva commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

build(aio): upgrade to 5.2.0-rc.0 #21351

build(aio): upgrade to 5.2.0-rc.0 #21351

Conversation

IgorMinar commented Jan 6, 2018

mary-poppins commented Jan 6, 2018

IgorMinar commented Jan 6, 2018 • edited

petebacondarwin commented Jan 8, 2018

gkalpak left a comment

Choose a reason for hiding this comment

gkalpak Jan 8, 2018

Choose a reason for hiding this comment

IgorMinar Jan 10, 2018

Choose a reason for hiding this comment

IgorMinar Jan 10, 2018

Choose a reason for hiding this comment

mary-poppins commented Jan 9, 2018

IgorMinar commented Jan 9, 2018

IgorMinar commented Jan 9, 2018

gkalpak commented Jan 9, 2018 • edited

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

IgorMinar commented Jan 10, 2018 • edited

mary-poppins commented Jan 10, 2018

filipesilva commented Jan 10, 2018

filipesilva commented Jan 10, 2018

mary-poppins commented Jan 10, 2018

angular-automatic-lock-bot bot commented Sep 13, 2019

IgorMinar commented Jan 6, 2018 •

edited

gkalpak commented Jan 9, 2018 •

edited

IgorMinar commented Jan 10, 2018 •

edited