test(common): make date pipe tests work in more timezones #21379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
target: patch
|
Travis fails because of the application size (that fails on master), it has nothing to do with my PR |
tariknz
reviewed
Jan 8, 2018
|
|
||
| it('should format invalid in Safari ISO date', | ||
| () => expect(pipe.transform('2017-01-20T19:00:00+0000')).toEqual('Jan 20, 2017')); | ||
| () => expect(pipe.transform('2017-01-20T12:00:00+0000')).toEqual('Jan 20, 2017')); | ||
|
|
There was a problem hiding this comment.
12 pm UTC is actually 1 am on Jan 21st in NZDT (+13:00) so "most" time zones.
There was a problem hiding this comment.
good point, I've updated the commit message :)
we could also handle this programmatically, we can get the timezone and change the expected result.
ocombe
force-pushed
the
fix/#21112-date-pipe-tests
branch
from
74d088d
to
183d727
Compare
ocombe
added
the
action: review
ocombe
changed the title
vicb
approved these changes
Jan 11, 2018
vicb
added
action: merge
alexeagle
pushed a commit
that referenced
this pull request
Jan 12, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some date pipe tests use a time that will return a different date depending on the timezone of the machine running the tests
Issue Number: #21112
What is the new behavior?
We set the time to 12h00 so that the test passes in all timezones
Does this PR introduce a breaking change?