New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): create consistent naming scheme across classes #21403
Conversation
You can preview fa32c0d at https://pr21403-fa32c0d.ngbuilds.io/. |
ef6d4f9
to
e795563
Compare
You can preview 1f67018 at https://pr21403-1f67018.ngbuilds.io/. |
You can preview ef6d4f9 at https://pr21403-ef6d4f9.ngbuilds.io/. |
You can preview e795563 at https://pr21403-e795563.ngbuilds.io/. |
You can preview a47ac36 at https://pr21403-a47ac36.ngbuilds.io/. |
You can preview 5372199 at https://pr21403-5372199.ngbuilds.io/. |
@kara it appears to break google3: http://test/OCL:181371945:BASE:181371976:1515535924109:db93d28d |
You can preview f2116b8 at https://pr21403-f2116b8.ngbuilds.io/. |
Talked offline: look like test flakes, so ready to merge. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This PR renames a number of classes so our naming pattern is consistent. We now have three prefixes:
R - Rendered objects (i.e. DOM)
L - Logical objects (one per template instance)
T - Template objects (static data saved on template function, shared across instances)
So for "Node", we have:
RNode
: rendered node on the DOMLNode
: instance-specific data for the nodeTNode
: static data for the node, saved on the template functionThis is just a rename PR. In follow-up PRs, we'll be splitting up the code to store more in the
T
objects, so we can avoid re-doing work across instances.Specific renames:
ViewState
->LView
ContainerState
->LContainer
ProjectionState
->LProjection
QueryState
->LQuery
LElement
->LElementNode
LText
->LTextNode
LContainer
->LContainerNode
LView
->LViewNode
(to differentiate from newLView
)LNodeStatic
->TNode
LElementStatic
->TElementNode
LContainerStatic
->TContainerNode
LNodeInjector
->LInjector