Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): create consistent naming scheme across classes #21403

Closed
wants to merge 1 commit into from

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 9, 2018

This PR renames a number of classes so our naming pattern is consistent. We now have three prefixes:

R - Rendered objects (i.e. DOM)
L - Logical objects (one per template instance)
T - Template objects (static data saved on template function, shared across instances)

So for "Node", we have:

  • RNode: rendered node on the DOM
  • LNode: instance-specific data for the node
  • TNode: static data for the node, saved on the template function

This is just a rename PR. In follow-up PRs, we'll be splitting up the code to store more in the T objects, so we can avoid re-doing work across instances.

Specific renames:

  • ViewState -> LView

  • ContainerState -> LContainer

  • ProjectionState -> LProjection

  • QueryState -> LQuery

  • LElement -> LElementNode

  • LText -> LTextNode

  • LContainer -> LContainerNode

  • LView -> LViewNode (to differentiate from new LView)

  • LNodeStatic -> TNode

  • LElementStatic -> TElementNode

  • LContainerStatic -> TContainerNode

  • LNodeInjector -> LInjector

@mary-poppins
Copy link

You can preview fa32c0d at https://pr21403-fa32c0d.ngbuilds.io/.

@kara kara force-pushed the refactor branch 3 times, most recently from ef6d4f9 to e795563 Compare January 9, 2018 05:13
@mary-poppins
Copy link

You can preview 1f67018 at https://pr21403-1f67018.ngbuilds.io/.

@kara kara requested a review from mhevery January 9, 2018 05:16
@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime target: major This PR is targeted for the next major release labels Jan 9, 2018
@mary-poppins
Copy link

You can preview ef6d4f9 at https://pr21403-ef6d4f9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e795563 at https://pr21403-e795563.ngbuilds.io/.

@mary-poppins
Copy link

You can preview a47ac36 at https://pr21403-a47ac36.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 5372199 at https://pr21403-5372199.ngbuilds.io/.

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 9, 2018
@alexeagle
Copy link
Contributor

@kara it appears to break google3: http://test/OCL:181371945:BASE:181371976:1515535924109:db93d28d

@mary-poppins
Copy link

You can preview f2116b8 at https://pr21403-f2116b8.ngbuilds.io/.

@kara
Copy link
Contributor Author

kara commented Jan 10, 2018

Talked offline: look like test flakes, so ready to merge.

@kara kara added comp: ivy and removed area: core Issues related to the framework runtime labels Jan 10, 2018
@kara kara closed this in fc3e7e0 Jan 10, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants