build: upgrade yarn to 1.3.2

[ocombe]

PR Type

What kind of change does this PR introduce?

[x] Build related changes

What is the current behavior?

We use yarn 1.0.2

Issue Number: #20566

What is the new behavior?

We use yarn 1.3.2

Does this PR introduce a breaking change?

[x] No

[mary-poppins]

You can preview 2d74c85 at https://pr21406-2d74c85.ngbuilds.io/.

[mary-poppins]

You can preview 06425b3 at https://pr21406-06425b3.ngbuilds.io/.

[IgorMinar]

don't we need to update the docker container? // @alexeagle

if we merge this as is, circle is going to use wrong version of yarn.

I'm also shocked to see that there are no changes to the yarn.lock file. Is this expected? if updated circle docker container is also green then we should merge this as is without any lock file changes.

thanks!

[alexeagle]

@IgorMinar should be good:

$ docker run --rm -it angular/ngcontainer:0.0.8
circleci@52269916ee5f:/$ yarn --version
1.3.2

[ocombe]

Yes, the circle ci docker is already using 1.3.2 apparently.
The lockfile is compatible with 1.3.2, nothing will change until we add new dependencies

[IgorMinar]

Awesome then!

[IgorMinar]

Once this lands in master and someone will use an old yarn version they'll get this error:

error angular.io@0.0.0: The engine "yarn" is incompatible with this module. Expected version ">=1.0.2 <1.2.0".

I think the error is actionable enough that we don't need a special team wide announcement. Let's get this in! :)

[IgorMinar]

@ocombe could you add a change to this PR (or send a new one) that would delegate the yarn vs npm check into a file in order to hide the ugly line "$ node -e "if(process.env.npm_execpath.indexOf('yarn') " that appears every time you run a yarn command. This line looks like an error, but it's really just a command that contains a possible error message, but that's not easy to tell for someone who's not familiar with the setup.

Current output for yarn install:

$ yarn install
yarn install v1.3.2
$ node -e "if(process.env.npm_execpath.indexOf('yarn') === -1) throw new Error('Please use Yarn instead of NPM to install dependencies. See: https://yarnpkg.com/lang/en/docs/install/')"
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
...

Desired output for yarn install:

yarn install v1.3.2
$ tools/yarn/yarn-check.js
[1/5] 🔍  Validating package.json...
[2/5] 🔍  Resolving packages...
[3/5] 🚚  Fetching packages...
...

[ocombe]

Sure I'll do that right now

[IgorMinar]

thanks!

[mary-poppins]

You can preview cff027c at https://pr21406-cff027c.ngbuilds.io/.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}