Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ivy): add Ivy as a recognized label #21428

Closed
wants to merge 1 commit into from
Closed

docs(ivy): add Ivy as a recognized label #21428

wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jan 9, 2018

No description provided.

@mhevery mhevery added target: patch This PR is targeted for the next patch release comp: ivy target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Jan 9, 2018
gkalpak
gkalpak reviewed Jan 9, 2018
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the tests here.

@IgorMinar IgorMinar self-requested a review January 9, 2018 22:01
IgorMinar
IgorMinar approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what George said - please update the tests.

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 9, 2018
@mhevery mhevery removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 9, 2018
@mhevery
Copy link
Contributor Author

mhevery commented Jan 9, 2018

done.

@mhevery mhevery force-pushed the ivy_label branch 2 times, most recently from c66ff18 to f1ed03d Compare January 10, 2018 00:52
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 10, 2018
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jan 10, 2018
alexeagle pushed a commit that referenced this pull request Jan 10, 2018
@mhevery @alexeagle
docs(ivy): add Ivy as a recognized label (#21428)
6a97b5b 
PR Close #21428
@alexeagle alexeagle closed this in a33ff2c Jan 10, 2018
@mhevery mhevery deleted the ivy_label branch February 14, 2018 23:01
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@mhevery @leo6104
docs(ivy): add Ivy as a recognized label (angular#21428)
efa5e6b 
PR Close angular#21428
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mhevery @IgorMinar @gkalpak @alexeagle @googlebot