Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel ruls for benchpress #21436

Closed
wants to merge 1 commit into from
Closed

Bazel ruls for benchpress #21436

wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Jan 10, 2018

No description provided.

alexeagle
alexeagle reviewed Jan 10, 2018
View reviewed changes
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's different from packages because you don't use a recursive glob. what's the reasoning there? it's a lot more maintenance work to have so many build files, at least until we have the tazel tool

@mhevery mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release comp: ivy labels Jan 10, 2018
@alexeagle alexeagle added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Jan 10, 2018
@alexeagle alexeagle closed this in ef956a2 Jan 10, 2018
alexeagle pushed a commit that referenced this pull request Jan 10, 2018
@mhevery @alexeagle
build: add bazel rulse for benchmarks (#21436)
167cbed 
PR Close #21436
@mhevery mhevery deleted the bazel branch February 14, 2018 23:01
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@mhevery @leo6104
build: add bazel rulse for benchmarks (angular#21436)
e8ba0e5 
PR Close angular#21436
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhevery @alexeagle @googlebot