Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(aio): run e2e tests in production mode #21470

Closed
wants to merge 1 commit into from
Closed

ci(aio): run e2e tests in production mode #21470

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jan 11, 2018

This will enable catching errors introduced by build optimizations that do not appear in development mode.

Fixes #21446.

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: patch This PR is targeted for the next patch release labels Jan 11, 2018
@gkalpak gkalpak changed the title test(aio): run e2e tests in production mode ci(aio): run e2e tests in production mode Jan 11, 2018
@gkalpak
ci(aio): run e2e tests in production mode
31440e6 
This will enable catching errors introduced by build optimizations that
do not appear in `development` mode.

Fixes angular#21446
@gkalpak gkalpak added this to REVIEW in docs-infra Jan 11, 2018
@mary-poppins
Copy link

You can preview 31440e6 at https://pr21470-31440e6.ngbuilds.io/.

@IgorMinar
Copy link
Contributor

Thanks!!

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 12, 2018
alexeagle pushed a commit that referenced this pull request Jan 12, 2018
@gkalpak @alexeagle
ci(aio): run e2e tests in production mode (#21470)
cf4bea5 
This will enable catching errors introduced by build optimizations that
do not appear in `development` mode.

Fixes #21446

PR Close #21470
@alexeagle alexeagle closed this in f6db952 Jan 12, 2018
@gkalpak gkalpak deleted the ci-aio-e2e-production branch January 12, 2018 22:36
@gkalpak gkalpak removed this from REVIEW in docs-infra Jan 15, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@gkalpak @leo6104
ci(aio): run e2e tests in production mode (angular#21470)
2297007 
This will enable catching errors introduced by build optimizations that
do not appear in `development` mode.

Fixes angular#21446

PR Close angular#21470
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run aio e2e tests in --prod mode to catch optimization issues
4 participants
@gkalpak @mary-poppins @IgorMinar @googlebot