Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(aio): add description and docs links for code samples #21561

Closed
wants to merge 1 commit into from
Closed

docs(aio): add description and docs links for code samples #21561

wants to merge 1 commit into from

Conversation

jasonaden
Copy link
Contributor

No description provided.

IgorMinar
IgorMinar approved these changes Jan 16, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm. thanks!

aio/README.md Outdated
@@ -68,6 +68,11 @@ The content is written in markdown.
All other content is written using markdown in text files, located in the `angular/aio/content` folder.
More specifically, there are sub-folders that contain particular types of content: guides, tutorial and marketing.

* **Code snippets & samples**: code samples and snippets need to be testable to ensure their accuracy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we use term "examples" everywhere instead of "samples". Can you correct that please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 16, 2018
@jasonaden jasonaden added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Jan 16, 2018
@ngbot
Copy link

ngbot bot commented Jan 16, 2018

I see that you just added the PR action: merge label. It won't do anything good though, because the following checks are still failing:
    failure missing required label: "PR target:"
    pending status "ci/circleci: build" is pending
    pending status "ci/circleci: lint" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the checks. But if you have a good reason to want to merge this, please contact the caretaker to let them know.

@jasonaden jasonaden added the target: patch This PR is targeted for the next patch release label Jan 16, 2018
@mary-poppins
Copy link

You can preview 543f4e0 at https://pr21561-543f4e0.ngbuilds.io/.

alexeagle pushed a commit that referenced this pull request Jan 17, 2018
@jasonaden @alexeagle
docs(aio): add description and docs links for code samples (#21561)
55f15c5 
PR Close #21561
@alexeagle alexeagle closed this in 6e8cf63 Jan 17, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
@jasonaden @jbogarthyde
docs(aio): add description and docs links for code samples (angular#2…
21659f0 
…1561)

PR Close angular#21561
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@jasonaden @leo6104
docs(aio): add description and docs links for code samples (angular#2…
5e316dd 
…1561)

PR Close angular#21561
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jasonaden @mary-poppins @IgorMinar @alexeagle @googlebot