docs(ivy): add feature principle doc #21565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Jan 16, 2018
| function queryContainerRefFeature() {...} | ||
| function queryTemplateRefFeature() {...} | ||
|
|
||
| query(predicate, descend, querElemntRefFeture) {...} |
There was a problem hiding this comment.
topys in queryElementRefFeature
vicb
reviewed
Jan 16, 2018
| nodeInjector: LInjector, node: LNode, read: QueryReadType | Type<any>): any { | ||
| if (read === QueryReadType.ElementRef) { | ||
| return getOrCreateElementRef(nodeInjector); | ||
| } else if (read === QueryReadType.ViewContainerRef) { |
There was a problem hiding this comment.
nit: could you remove elses after returns (everywhere in this PR)
There was a problem hiding this comment.
This is cut and paste from actual code, but I will remove it.
vicb
reviewed
Jan 16, 2018
| ``` | ||
| function readFromNodeInjector( | ||
| nodeInjector: LInjector, node: LNode, read: QueryReadType | Type<any>): any { | ||
| if (isFeature(read) { |
vicb
reviewed
Jan 16, 2018
|
|
||
| ``` | ||
| function readFromNodeInjector( | ||
| nodeInjector: LInjector, node: LNode, read: QueryReadType | Type<any>): any { |
intellix
reviewed
Jan 16, 2018
|
|
||
| The issue is that once the `query` instruction is pulled in it will pull in `ElementRef`, `ContainerRef`, and `TemplateRef` regardless if the `query` instruction queries for them. | ||
|
|
||
| A better way to do this is to encapsulate the work into a object or function which than will be passed into the `query` instead of the enumeration. |
There was a problem hiding this comment.
a object -> an object
than will -> will then
vicb
reviewed
Jan 16, 2018
| } | ||
| ``` | ||
|
|
||
| This approach allots us to preserve the tree-shaking. In essence the if statement has moved from runtime (non-tree-shakable) to compile time (tree-shakable) position. |
vicb
added
action: cleanup
mhevery
removed
the
action: cleanup
vicb
reviewed
Jan 16, 2018
|
|
||
| ``` | ||
| function readFromNodeInjector( | ||
| nodeInjector: LInjector, node: LNode, readFn: QueryReadType | Type<any>): any { |
There was a problem hiding this comment.
Change the type in readFn: QueryReadType | Type<any> to (Injector) => any ?
vicb
suggested changes
Jan 16, 2018
vicb
approved these changes
Jan 16, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.