docs: several small fixes/improvements/refactorings for the guides #21589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
added
comp: docs
action: review
kapunahelewong
approved these changes
Jan 17, 2018
ocombe
added
comp: docs
action: review
|
You can preview 2163fb1 at https://pr21589-2163fb1.ngbuilds.io/. |
aio/content/guide/feature-modules.md
Outdated
| @@ -130,5 +126,3 @@ You may also be interested in the following: | |||
| * [Lazy Loading Modules with the Angular Router](guide/lazy-loading-ngmodules). | |||
| * [Providers](guide/providers). | |||
| * [Types of NgModules](guide/module-types). | |||
There was a problem hiding this comment.
Does the text for this link need to change to Types of Feature Modules ?
| @@ -189,4 +189,3 @@ The following table summarizes the key characteristics of each feature module gr | |||
| You may also be interested in the following: | |||
| * [Lazy Loading Modules with the Angular Router](guide/lazy-loading-ngmodules). | |||
| * [Providers](guide/providers). | |||
| * [Types of NgModules](guide/module-types). | |||
There was a problem hiding this comment.
LOL - you might also be interested in "this page"!
aio/content/guide/ngmodule-api.md
Outdated
| <ol> | ||
| <li>When compiling a template, you need to determine a set of selectors which should be used for triggering their corresponding directives.</li> | ||
| <li> | ||
| The template is compiled within a context of an `NgModule`—the `NgModule` which this template's component is declared in—which determines the set of selectors using the following rules: |
There was a problem hiding this comment.
"the NgModule within which the template's component is declared"
aio/content/guide/ngmodule-api.md
Outdated
| The template is compiled within a context of an `NgModule`—the `NgModule` which this template's component is declared in—which determines the set of selectors using the following rules: | ||
| <ul> | ||
| <li>All selectors of directives listed in `declarations`.</li> | ||
| <li>All exported selectors of imported `NgModules`.</li> |
There was a problem hiding this comment.
"All selectors of directives exported from imported NgModules"?
aio/content/guide/ngmodule-api.md
Outdated
|
|
||
| <tr> | ||
| A list of modules which should be folded into this module. Folded means it is | ||
| as if all of the imported NgModule properties were declared here. |
There was a problem hiding this comment.
"all the imported NgModule's exported properties"
aio/content/guide/ngmodule-faq.md
Outdated
|
|
||
| ## What should I export? | ||
|
|
||
| Export [declarable](guide/bootstrapping#the-declarations-array) classes that components in _other_ NgModules | ||
| are able to reference in their templates. These are your _public_ classes. | ||
| If you don't export a class, it stays _private_, visible only to other component | ||
| If you don't export a declarable class, it stays _private_, visible only to other component |
| @@ -55,13 +55,13 @@ of some of the things they contain: | |||
|
|
|||
| <tr> | |||
| <td><code>RouterModule</code></td> | |||
| <td><code>@angular/forms</code></td> | |||
| <td><code>@angular/router</code></td> | |||
|
|
||
| <hr /> | ||
|
|
||
| ## Providing a singleton service | ||
|
|
||
| An injector created from a module definition will have services which are singletons with respect to that injector. To control the lifetime of services, one controls the creation and destruction of injectors. For example, a route will have an associated module. When the route is activated, an injector is created from that module as a child of the current injector. When you navigate away from the route, the injector is destroyed. This means that services declared in a route module will have a lifetime equal to that of the route. Similarly, services provided in an application module will have the same lifetime of the application, hence singleton. | ||
| An injector created from a module definition will have services which are singletons with respect to that injector. To control the lifetime of services, one controls the creation and destruction of injectors. For example, a route will have an associated module. When the route is activated, an injector is created from that module as a child of the current injector. When you navigate away from the route, the injector is destroyed. This means that services declared in a route module will have a lifetime equal to that of the route. Similarly, services provided in an application module will have the same lifetime of the application, hence singleton. |
There was a problem hiding this comment.
Surely this line should be broken into shorter lines?
There was a problem hiding this comment.
I wish all lines were limited to 100 chars :)
petebacondarwin
approved these changes
Jan 17, 2018
petebacondarwin
added
action: cleanup
gkalpak
force-pushed
the
docs-aio-fix-ngmodules
branch
from
2163fb1
to
d53e55c
Compare
|
You can preview d53e55c at https://pr21589-d53e55c.ngbuilds.io/. |
gkalpak
added
action: merge
|
Incorporated @petebacondarwin's suggestions. ❤️ |
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
mhevery
pushed a commit
that referenced
this pull request
Jan 19, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…-snippets lang) (angular#21589) PR Close angular#21589
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…-snippets lang) (angular#21589) PR Close angular#21589
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Tests for the changes have been added (for bug fixes / features)PR Type
What is the current behavior?
Some minor issues (typos, inconsistentcies, wrong/incomplete examples).
What is the new behavior?
Less minor issues.
Does this PR introduce a breaking change?
Related: #21517, #21531