Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): avoid triggering a cli bug #21611

Merged
merged 1 commit into from Jan 17, 2018

Conversation

chuckjaz
Copy link
Contributor

Temporary update to the package.json file until CLI is fixed to
handle 6.0 builds.

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

AIO CI is broken due to a version check issue in the CLI.

What is the new behavior?

AIO CI passes.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@chuckjaz chuckjaz added area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release labels Jan 17, 2018
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could be sneaky and add a comment like this

"version": "TODO this should be 6.0.0-beta.0, workaround",
"version": "5.9.9",

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the comment as suggested by @alexeagle otherwise lgtm

@IgorMinar IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 17, 2018
Temporary update to the package.json file until CLI is fixed to
handle 6.0 builds.
@chuckjaz chuckjaz removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 17, 2018
@chuckjaz chuckjaz merged commit 0eabd07 into angular:master Jan 17, 2018
hansl added a commit to hansl/angular that referenced this pull request Jan 19, 2018
hansl added a commit to hansl/angular that referenced this pull request Jan 24, 2018
hansl added a commit to hansl/angular that referenced this pull request Jan 24, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
Temporary update to the package.json file until CLI is fixed to
handle 6.0 builds.
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
Temporary update to the package.json file until CLI is fixed to
handle 6.0 builds.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants