Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bazel): pass around tsconfig as a file, not a path #21614

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

this unlocks the ability to replay ts compilations with different settings

@alexeagle
Copy link
Contributor Author

Note to caretaker @chuckjaz : this requires cl/182267196

@mary-poppins
Copy link

You can preview f7b906a at https://pr21614-f7b906a.ngbuilds.io/.

@chuckjaz chuckjaz added the area: build & ci Related the build and CI infrastructure of the project label Jan 17, 2018
@mary-poppins
Copy link

You can preview f1bcfee at https://pr21614-f1bcfee.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 592f3a5 at https://pr21614-592f3a5.ngbuilds.io/.

@alexeagle alexeagle added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 19, 2018
this unlocks the ability to replay ts compilations with different settings
@mary-poppins
Copy link

You can preview 6bff54a at https://pr21614-6bff54a.ngbuilds.io/.

@alexeagle alexeagle closed this in 1104d17 Jan 19, 2018
mhevery pushed a commit that referenced this pull request Jan 23, 2018
this unlocks the ability to replay ts compilations with different settings

PR Close #21614
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
…21614)

this unlocks the ability to replay ts compilations with different settings

PR Close angular#21614
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
…21614)

this unlocks the ability to replay ts compilations with different settings

PR Close angular#21614
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants