-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add notes on email used for CLA #21754
docs: add notes on email used for CLA #21754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
In the future please add The commit message should have read:
(the blank line after the first line is intentional per git conventions) Because the "Closes" clause is missing, we'll need to close the issue manually once the commit message lands. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rushed my original review. Please see the comments above. And since you are changing the PR can you as well change the commit message per my comment #21754 (comment)
thanks!
CONTRIBUTING.md
Outdated
@@ -259,6 +259,19 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise | |||
* For corporations we'll need you to | |||
[print, sign and one of scan+email, fax or mail the form][corporate-cla]. | |||
|
|||
<div class="l-sub-section"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops. I missed this. This markdown file, is just hosted on github and is not part of the angular.io documentation corpus. Because of that the special classes have no meeting and I suggest that you remove them to prevent the confusion.
CONTRIBUTING.md
Outdated
|
||
Note that if you have more than one Git identity, it is important to verify that you are logged in with the same ID with which you signed the CLA, before you commit changes. If not, your PR will fail the CLA check. | ||
|
||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see above
You can preview 18de817 at https://pr21754-18de817.ngbuilds.io/. |
I tried to do this, but got the message wrong, tried to fix it and made it worse. Now there are all these extra files added from somewhere, and I think the actual file changes didn't get in. |
18de817
to
f258cf8
Compare
You can preview f258cf8 at https://pr21754-f258cf8.ngbuilds.io/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks correct to me. thanks!
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 20034
What is the new behavior?
Does this PR introduce a breaking change?
Other information