Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add notes on email used for CLA #21754

Closed

Conversation

jbogarthyde
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 20034

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@IgorMinar IgorMinar added comp: docs target: patch This PR is targeted for the next patch release labels Jan 26, 2018
@IgorMinar IgorMinar changed the title docs: add notes on email used for CLA (20034) docs: add notes on email used for CLA Jan 26, 2018
@IgorMinar
Copy link
Contributor

In the future please add Closes #20034 on a new line at the bottom of the commit message. This will associate the commit with the issue that is being fixed and the issue will be fixed automatically once the commit is merged into master.

The commit message should have read:

docs: add notes on email used for CLA

Closes #20034

(the blank line after the first line is intentional per git conventions)

Because the "Closes" clause is missing, we'll need to close the issue manually once the commit message lands.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rushed my original review. Please see the comments above. And since you are changing the PR can you as well change the commit message per my comment #21754 (comment)

thanks!

CONTRIBUTING.md Outdated
@@ -259,6 +259,19 @@ changes to be accepted, the CLA must be signed. It's a quick process, we promise
* For corporations we'll need you to
[print, sign and one of scan+email, fax or mail the form][corporate-cla].

<div class="l-sub-section">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops. I missed this. This markdown file, is just hosted on github and is not part of the angular.io documentation corpus. Because of that the special classes have no meeting and I suggest that you remove them to prevent the confusion.

CONTRIBUTING.md Outdated

Note that if you have more than one Git identity, it is important to verify that you are logged in with the same ID with which you signed the CLA, before you commit changes. If not, your PR will fail the CLA check.

</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@IgorMinar IgorMinar self-assigned this Jan 26, 2018
@mary-poppins
Copy link

You can preview 18de817 at https://pr21754-18de817.ngbuilds.io/.

@jbogarthyde
Copy link
Contributor Author

jbogarthyde commented Jan 26, 2018

I tried to do this, but got the message wrong, tried to fix it and made it worse. Now there are all these extra files added from somewhere, and I think the actual file changes didn't get in.
I'll try to work with George to fix it tomorrow.
...and George fixed it! Thank you George!

@mary-poppins
Copy link

You can preview f258cf8 at https://pr21754-f258cf8.ngbuilds.io/.

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks correct to me. thanks!

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Jan 26, 2018
@mhevery mhevery closed this in e608052 Jan 26, 2018
mhevery pushed a commit that referenced this pull request Jan 26, 2018
@jbogarthyde jbogarthyde deleted the jb-update-git-email-for-cla branch February 9, 2018 16:14
jbogarthyde added a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants