build(aio): upgrade CLI version to cope with new Angular 6.0.0-beta.1 release #21772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
added
area: build & ci
petebacondarwin
force-pushed
the
aio-upgrade-example-cli
branch
from
9af4a2b
to
cec3707
Compare
gkalpak
approved these changes
Jan 25, 2018
This was referenced Jan 25, 2018
|
You can preview cec3707 at https://pr21772-cec3707.ngbuilds.io/. |
petebacondarwin
removed
the
action: review
|
You can preview 569f718 at https://pr21772-569f718.ngbuilds.io/. |
petebacondarwin
force-pushed
the
aio-upgrade-example-cli
branch
2 times, most recently
from
e789c6c
to
5d8b7c9
Compare
petebacondarwin
commented
Jan 25, 2018
| @@ -177,8 +177,8 @@ to a component's `@Component` decorator: | |||
|
|
|||
| <code-tabs> | |||
| <code-pane title="src/app/hero-app.component.ts (CSS in file)" path="component-styles/src/app/hero-app.component.1.ts"></code-pane> | |||
| <code-pane title="src/app/hero-app.component.css" path="component-styles/src/app/hero-app.component.1.css"></code-pane> | |||
| </code-tabs> | |||
| <code-pane title="src/app/hero-app.component.css" path="component-styles/src/app/hero-app.component.css"></code-pane> | |||
There was a problem hiding this comment.
This is the only significant change in this file.
The rest is just trailing whitespace removal
There was a problem hiding this comment.
Why rename it? AFAICT, the file wan intentionally suffixed .1.css, so that it would not be included n stackblitz/zip.
There was a problem hiding this comment.
Because there is a component that references this file (without the 1) and breaks the build if the file is not there.
It is a trade off we could rename it in that component but then the 1 would leak into the docs.
… release Before version 1.6 of Angular CLI there was a check that prevented use of Angular compiler CLI with major version 6.
The AOT compiler needs relative paths so that it can find the imported stylesheets.
The code in the example was referring to `hero-app.component.css` but this did not exist.
petebacondarwin
force-pushed
the
aio-upgrade-example-cli
branch
from
5d8b7c9
to
0e7b6d5
Compare
|
You can preview 0e7b6d5 at https://pr21772-0e7b6d5.ngbuilds.io/. |
petebacondarwin
added
the
action: merge
mhevery
pushed a commit
that referenced
this pull request
Jan 25, 2018
The AOT compiler needs relative paths so that it can find the imported stylesheets. PR Close #21772
mhevery
pushed a commit
that referenced
this pull request
Jan 25, 2018
The code in the example was referring to `hero-app.component.css` but this did not exist. PR Close #21772
mhevery
pushed a commit
that referenced
this pull request
Jan 25, 2018
The AOT compiler needs relative paths so that it can find the imported stylesheets. PR Close #21772
mhevery
pushed a commit
that referenced
this pull request
Jan 25, 2018
The code in the example was referring to `hero-app.component.css` but this did not exist. PR Close #21772
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
… release (angular#21772) Before version 1.6 of Angular CLI there was a check that prevented use of Angular compiler CLI with major version 6. PR Close angular#21772
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
The AOT compiler needs relative paths so that it can find the imported stylesheets. PR Close angular#21772
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…r#21772) The code in the example was referring to `hero-app.component.css` but this did not exist. PR Close angular#21772
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
… release (angular#21772) Before version 1.6 of Angular CLI there was a check that prevented use of Angular compiler CLI with major version 6. PR Close angular#21772
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
The AOT compiler needs relative paths so that it can find the imported stylesheets. PR Close angular#21772
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…r#21772) The code in the example was referring to `hero-app.component.css` but this did not exist. PR Close angular#21772
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should un-break master.
Before version 1.6 of Angular CLI there was a check that prevented use of Angular
compiler CLI with major version 6.