test(ivy): add canonical lifecycle example #21793

kara · 2018-01-26T03:20:19Z

Adds an example of lifecycle hooks to the canonical spec. Also flips r() calls for content children in lifecycle spec (it was left over from a previous implementation).

cc @jelbourn

mary-poppins · 2018-01-26T21:48:50Z

You can preview 3954c64 at https://pr21793-3954c64.ngbuilds.io/.

mary-poppins · 2018-01-26T21:59:54Z

You can preview 0135b3f at https://pr21793-0135b3f.ngbuilds.io/.

chuckjaz · 2018-01-26T22:30:13Z

packages/core/test/render3/compiler_canonical_spec.ts

+
+    @Component({selector: 'lifecycle-comp', template: ``})
+    class LifecycleComp {
+      @Input() nameMin: string;


@Input('name')

Good catch!

chuckjaz · 2018-01-26T22:31:11Z

packages/core/test/render3/compiler_canonical_spec.ts

+      static ngComponentDef = r3.defineComponent({
+        type: LifecycleComp,
+        tag: 'lifecycle-comp',
+        factory: () => new LifecycleComp(),


factory: function LifecycleComp_Factory() { return new LifecycleComp(); },

This is optional (since this is non-normative) but would be more consistent.

chuckjaz · 2018-01-26T22:32:16Z

packages/core/test/render3/compiler_canonical_spec.ts

+        type: LifecycleComp,
+        tag: 'lifecycle-comp',
+        factory: () => new LifecycleComp(),
+        template: function(ctx: any, cm: boolean) {},


template: function LifecycleComp_Template(ctx: LifecycleComp, cm: boolean) {}

This is optional (since this is non-normative) but would be more consistent.

chuckjaz · 2018-01-26T22:32:47Z

packages/core/test/render3/compiler_canonical_spec.ts

+      name1 = '1';
+      name2 = '2';
+
+      static ngComponentDef = r3.defineComponent({


Add // NORMATIVE above this declaration

chuckjaz · 2018-01-26T22:33:08Z

packages/core/test/render3/compiler_canonical_spec.ts

+        }
+      });
+    }
+


Add \\ /NORMANTIVE

chuckjaz · 2018-01-26T22:33:38Z

packages/core/test/render3/compiler_canonical_spec.ts

+      static ngComponentDef = r3.defineComponent({
+        type: SimpleLayout,
+        tag: 'simple-layout',
+        factory: () => new SimpleLayout(),


factory SimpleLayout_Factory() { return new SimpleLayout(); }

chuckjaz · 2018-01-26T22:34:11Z

packages/core/test/render3/compiler_canonical_spec.ts

+        type: SimpleLayout,
+        tag: 'simple-layout',
+        factory: () => new SimpleLayout(),
+        template: function(ctx: any, cm: boolean) {


function SimpleLayout_Template(ctx: SimpleLayout, cm: boolean) {

chuckjaz · 2018-01-26T22:38:02Z

packages/core/test/render3/compiler_canonical_spec.ts

+      static ngComponentDef = r3.defineComponent({
+        type: SimpleLayout,
+        tag: 'simple-layout',
+        factory: () => simpleLayout = new SimpleLayout(),


factory: function SimpleLayout_Factory() { return new SimpleLayout(); }

chuckjaz · 2018-01-26T22:38:32Z

packages/core/test/render3/compiler_canonical_spec.ts

+        type: SimpleLayout,
+        tag: 'simple-layout',
+        factory: () => simpleLayout = new SimpleLayout(),
+        template: function(ctx: any, cm: boolean) {


template: function SimpleLayout_Template(ctx: SimpleLayout, cm: boolean) {

PR Close #21793

Implement the lifecycle pattern defined in angular#21793

Implement the lifecycle pattern defined in #21793 PR Close #21865

PR Close angular#21793

Implement the lifecycle pattern defined in angular#21793 PR Close angular#21865

PR Close angular#21793

Implement the lifecycle pattern defined in angular#21793 PR Close angular#21865

angular-automatic-lock-bot · 2019-09-13T05:52:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

test(ivy): add canonical lifecycle example

5935696

googlebot added the cla: yes label Jan 26, 2018

kara requested a review from mhevery January 26, 2018 03:21

kara added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release comp: ivy labels Jan 26, 2018

mhevery approved these changes Jan 26, 2018

View reviewed changes

mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 26, 2018

fix(ivy): call onChanges before onInit

0135b3f

kara force-pushed the canonical branch from 3954c64 to 0135b3f Compare January 26, 2018 21:52

kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 26, 2018

mhevery approved these changes Jan 26, 2018

View reviewed changes

mhevery added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 26, 2018

chuckjaz suggested changes Jan 26, 2018

View reviewed changes

jasonaden closed this in d3d3f71 Jan 26, 2018

jasonaden pushed a commit that referenced this pull request Jan 26, 2018

fix(ivy): call onChanges before onInit (#21793)

dcca799

PR Close #21793

kara mentioned this pull request Jan 26, 2018

test(ivy): normalize template names in canonical spec #21815

Closed

chuckjaz added a commit to chuckjaz/angular that referenced this pull request Jan 29, 2018

fix(ivy): generate lifecycle pattern

6ba164d

Implement the lifecycle pattern defined in angular#21793

chuckjaz mentioned this pull request Jan 29, 2018

fix(ivy): generate lifecycle pattern #21865

Closed

chuckjaz added a commit to chuckjaz/angular that referenced this pull request Jan 31, 2018

fix(ivy): generate lifecycle pattern

bd11df6

Implement the lifecycle pattern defined in angular#21793

alxhub pushed a commit that referenced this pull request Feb 2, 2018

fix(ivy): generate lifecycle pattern (#21865)

f816666

Implement the lifecycle pattern defined in #21793 PR Close #21865

jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

test(ivy): add canonical lifecycle example (angular#21793)

5a72399

PR Close angular#21793

jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

fix(ivy): call onChanges before onInit (angular#21793)

a1f3322

PR Close angular#21793

jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018

fix(ivy): generate lifecycle pattern (angular#21865)

caa2027

Implement the lifecycle pattern defined in angular#21793 PR Close angular#21865

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

test(ivy): add canonical lifecycle example (angular#21793)

a843c82

PR Close angular#21793

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

fix(ivy): call onChanges before onInit (angular#21793)

25178f5

PR Close angular#21793

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

fix(ivy): generate lifecycle pattern (angular#21865)

2755989

Implement the lifecycle pattern defined in angular#21793 PR Close angular#21865

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(ivy): add canonical lifecycle example #21793

test(ivy): add canonical lifecycle example #21793

kara commented Jan 26, 2018 •

edited

mary-poppins commented Jan 26, 2018

mary-poppins commented Jan 26, 2018

chuckjaz Jan 26, 2018

kara Jan 26, 2018

chuckjaz Jan 26, 2018

chuckjaz Jan 26, 2018

chuckjaz Jan 26, 2018

chuckjaz Jan 26, 2018

chuckjaz Jan 26, 2018

chuckjaz Jan 26, 2018

chuckjaz Jan 26, 2018 •

edited

chuckjaz Jan 26, 2018 •

edited

angular-automatic-lock-bot bot commented Sep 13, 2019

test(ivy): add canonical lifecycle example #21793

test(ivy): add canonical lifecycle example #21793

Conversation

kara commented Jan 26, 2018 • edited

mary-poppins commented Jan 26, 2018

mary-poppins commented Jan 26, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chuckjaz Jan 26, 2018 • edited

Choose a reason for hiding this comment

chuckjaz Jan 26, 2018 • edited

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 13, 2019

kara commented Jan 26, 2018 •

edited

chuckjaz Jan 26, 2018 •

edited

chuckjaz Jan 26, 2018 •

edited