fix(aio): don't set noindex metatag in the static index.html #21816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be causing crawling issues for google. Ref angular#21665
IgorMinar
added
action: review
|
I intentionally left all the removal code in (https://github.com/angular/angular/pull/21665/files#diff-bb389813000bdeab943f6fab6d39e4e8R175). there is no harm in trying to remove a non-existent tag during the initial rendering. |
|
You can preview ce87346 at https://pr21816-ce87346.ngbuilds.io/. |
|
@mhevery can you please approve so that we can ship this to prod today? I expect all the tests to pass, if not I'll deal with that. thanks |
petebacondarwin
approved these changes
Jan 26, 2018
IgorMinar
added
action: merge
mhevery
approved these changes
Jan 27, 2018
jasonaden
pushed a commit
that referenced
this pull request
Jan 27, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
…#21816) This seems to be causing crawling issues for google. Ref angular#21665 PR Close angular#21816
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
…#21816) This seems to be causing crawling issues for google. Ref angular#21665 PR Close angular#21816
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be causing crawling issues for google.
Ref #21665