Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(forms): update test name with correct wording #21833

Closed
wants to merge 1 commit into from

Conversation

benbraou
Copy link
Contributor

Use the term primitive value instead of standalone

Fixes #21831

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: merge The PR is ready for merge by the caretaker labels Jan 30, 2018
@kara
Copy link
Contributor

kara commented Jan 30, 2018

@benbraou Can you re-write the commit message to read: test(forms): update test name with correct wording?

@kara kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 30, 2018
@kara kara changed the title fix(forms): update test name with correct wording test(forms): update test name with correct wording Jan 30, 2018
Use the term primitive value instead of standalone

Fixes angular#21831
@benbraou
Copy link
Contributor Author

benbraou commented Feb 1, 2018

@kara done. Thanks

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 1, 2018
mhevery pushed a commit that referenced this pull request Feb 7, 2018
Use the term primitive value instead of standalone

Fixes #21831

PR Close #21833
@mhevery mhevery closed this in 54a1431 Feb 7, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
Use the term primitive value instead of standalone

Fixes angular#21831

PR Close angular#21833
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
Use the term primitive value instead of standalone

Fixes angular#21831

PR Close angular#21833
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: forms cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update test name in form_builder_spec.ts
4 participants