New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aio): structural directives. no path in navigation menu. fix #21856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great catch. LGTM. You may want to edit the commit message to be something like "docs(aio): put structural directives back in the nav". The structure of the part after the colon should start with the verb. "Fix" would be fine, too. Thank you so much @Yerkon!
Thanks @kapunahelewong. I will update commit message to 'docs(aio): put structural directives back in the nav' |
aio/content/navigation.json
Outdated
{ | ||
"url":"guide/structural-directives", | ||
"title": "Structural Directives", | ||
"tooltip": "Structural directives manipulate the layout of the page" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add .
at the end for consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
@gkalpak, how long PR staying opened? There are 300 PRs. Why are they still opeded at least old? |
aio/content/navigation.json
Outdated
@@ -170,6 +170,11 @@ | |||
"title": "Attribute Directives", | |||
"tooltip": "Attribute directives attach behavior to elements." | |||
}, | |||
{ | |||
"url":"guide/structural-directives", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you put a space after :
for consistency?
@Yerkon, PRs remain open until they are in a mergeable state (all CIs green, cla signed, approved by team member, review comments addressed) and marked for merge. It wouldn't be practical for us to regularly check all open PRs to find out if everything had been addressed. Once you have addressed all comments, you can comment saying the PR is ready for us to take another look. Once everything is fine, we mark the PR for merge (which then usually takes a few hours). |
All clear, thank you! |
@gkalpak, Done |
c8fd070
to
a2059a5
Compare
I've squashed the commits for you 😉 |
What could be better than helping to make an Angular better 😎 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #21848
What is the new behavior?
Structural directives page link added to navigation menu
Does this PR introduce a breaking change?
Other information