Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): structural directives. no path in navigation menu. fix #21856

Closed
wants to merge 1 commit into from

Conversation

Yerkon
Copy link
Contributor

@Yerkon Yerkon commented Jan 29, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #21848

What is the new behavior?

Structural directives page link added to navigation menu

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Contributor

@kapunahelewong kapunahelewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great catch. LGTM. You may want to edit the commit message to be something like "docs(aio): put structural directives back in the nav". The structure of the part after the colon should start with the verb. "Fix" would be fine, too. Thank you so much @Yerkon!

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 29, 2018
@Yerkon
Copy link
Contributor Author

Yerkon commented Jan 29, 2018

Thanks @kapunahelewong. I will update commit message to 'docs(aio): put structural directives back in the nav'

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Jan 30, 2018
{
"url":"guide/structural-directives",
"title": "Structural Directives",
"tooltip": "Structural directives manipulate the layout of the page"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add . at the end for consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@Yerkon
Copy link
Contributor Author

Yerkon commented Feb 10, 2018

@gkalpak, how long PR staying opened? There are 300 PRs. Why are they still opeded at least old?

@@ -170,6 +170,11 @@
"title": "Attribute Directives",
"tooltip": "Attribute directives attach behavior to elements."
},
{
"url":"guide/structural-directives",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a space after : for consistency?

@gkalpak
Copy link
Member

gkalpak commented Feb 10, 2018

@Yerkon, PRs remain open until they are in a mergeable state (all CIs green, cla signed, approved by team member, review comments addressed) and marked for merge. It wouldn't be practical for us to regularly check all open PRs to find out if everything had been addressed. Once you have addressed all comments, you can comment saying the PR is ready for us to take another look.

Once everything is fine, we mark the PR for merge (which then usually takes a few hours).

@Yerkon
Copy link
Contributor Author

Yerkon commented Feb 10, 2018

All clear, thank you!

@Yerkon
Copy link
Contributor Author

Yerkon commented Feb 10, 2018

@gkalpak, Done

@gkalpak
Copy link
Member

gkalpak commented Feb 10, 2018

I've squashed the commits for you 😉
Waiting for CIs to be green and will mark for merge. Thx for fixing this, @Yerkon 👍

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 10, 2018
@Yerkon
Copy link
Contributor Author

Yerkon commented Feb 10, 2018

What could be better than helping to make an Angular better 😎

@mhevery mhevery closed this in a57df4e Feb 12, 2018
mhevery pushed a commit that referenced this pull request Feb 12, 2018
@Yerkon Yerkon deleted the docs(aio)-fix branch February 13, 2018 03:33
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours freq3: high target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants