-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ivy): generate lifecycle pattern #21865
Conversation
You can preview 6ba164d at https://pr21865-6ba164d.ngbuilds.io/. |
Hi @chuckjaz! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
Hi @chuckjaz! This PR has merge conflicts due to recent upstream merges. |
Implement the lifecycle pattern defined in angular#21793
6ba164d
to
bd11df6
Compare
{key: 'inputs', quoted: false, value: mapToExpression(component.inputs)}); | ||
} | ||
|
||
// e.g. `features: [NgOnChangesFeature(MyComponent)]` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the type will be present on DirectiveDef
again, so it will just be features: [NgOnChangesFeature]
in the near future.
You can preview bd11df6 at https://pr21865-bd11df6.ngbuilds.io/. |
Implement the lifecycle pattern defined in angular#21793 PR Close angular#21865
Implement the lifecycle pattern defined in angular#21793 PR Close angular#21865
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Implement the lifecycle pattern defined in #21793
Does this PR introduce a breaking change?