Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): generate lifecycle pattern #21865

Closed
wants to merge 1 commit into from

Conversation

chuckjaz
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the new behavior?

Implement the lifecycle pattern defined in #21793

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@mary-poppins
Copy link

You can preview 6ba164d at https://pr21865-6ba164d.ngbuilds.io/.

@chuckjaz chuckjaz added the target: major This PR is targeted for the next major release label Jan 29, 2018
@ngbot
Copy link

ngbot bot commented Jan 30, 2018

Hi @chuckjaz! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

1 similar comment
@ngbot
Copy link

ngbot bot commented Jan 30, 2018

Hi @chuckjaz! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

Implement the lifecycle pattern defined in angular#21793
{key: 'inputs', quoted: false, value: mapToExpression(component.inputs)});
}

// e.g. `features: [NgOnChangesFeature(MyComponent)]`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the type will be present on DirectiveDef again, so it will just be features: [NgOnChangesFeature] in the near future.

@mary-poppins
Copy link

You can preview bd11df6 at https://pr21865-bd11df6.ngbuilds.io/.

@chuckjaz chuckjaz added the action: merge The PR is ready for merge by the caretaker label Feb 1, 2018
@alxhub alxhub closed this in f816666 Feb 2, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
Implement the lifecycle pattern defined in angular#21793

PR Close angular#21865
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
Implement the lifecycle pattern defined in angular#21793

PR Close angular#21865
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants