Automate PR workflow via github robot

[IgorMinar]

The robot could help us manage the PR workflow by watching activity on PRs and moving PRs into various milestones depending on the activity observed on the PR. The proposed milestones are captured on the following diagram as nodes (ovals) and actions that cause transitions are the annotated edges in the graph.

I used color coding to capture who's responsible for the next state transition.

There might be some exceptional state transitions are missing in this diagram, we should try to capture and document as many as we can.

@ocombe can you take a stab at this? thanks!

[ocombe]

Do you have a higher resolution for the image? I cannot read the small text

[IgorMinar]

oops.. sorry. I'll upload a better quality picture this evening.

[IgorMinar]

updated. @ocombe please let me know if you have questions.

@vicb suggested that we actually use some open source state machine library to implement this. he said that he would reach out to you to discuss this in detail.

One more thing: several of us discussed today that using "PR assignee" could be used to indicate who should take the next action. So for example any time we are in the "green" state, the issue is assigned to the original reviewer, but if we are in the blue state, the PR is assigned to the PR author (the bot would then correctly restore previous team assignee when we need to follow up). This would allow the team members to just watch the issues and PR assigned to them and follow up on those, simplifying the whole process of figuring out what issues to follow up on.

fyi: @kara @jasonaden @manughub @mhevery

[StephenFluin]

Can we change "Dead" to "Pending Close"?

[manughub]

Can we add a timeout between "work in progress" ands "inactive" states ?

[manughub]

Also need another bubble between "new PR" and "needs triage" state. This is the no milestone state (that will be used for caretaker L1 triage)

[ocombe]

New graph: https://docs.google.com/drawings/d/1PStuvppgz5ksyEtPtxjMzKe6uirQUImmqbLEbX9kWr8/edit?usp=sharing

[manekinekko]

@ocombe the doc seems to be private. is that intentional?

[ocombe]

Not really, I've changed the access rights, but I'm just adding the link here so that we don't loose it, I don't think it has much value to anyone else :)
But I think that manu has created it with his Google account, meaning it cannot be accessed by anyone outside of our organization

[davegaeddert]

I would actually be interested in taking a look at the doc if nobody is opposed? I run pullapprove, and am always curious to see what more complex projects are thinking around PR workflows. I can request access through Drive, just thought I would check here first.

[ocombe]

@manughub can you make the doc public please?

[davegaeddert]

Any word on this? Still looks to be private.

[manughub]

@davegaeddert here you go. I had to move the doc to a different domain to share it.
http://bit.ly/AngularPRProcess

[davegaeddert]

Awesome, thanks @manughub!

[angular-robot]

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

[angular-robot]

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

[AndrewKushnir]

This feature will be taken care of in the dev-infra repository (there is a proposed project), so I'm closing this ticket.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}