Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unblock master by ignoring date pipe tests while we fix it #21906

Closed
wants to merge 1 commit into from

Conversation

ocombe
Copy link
Contributor

@ocombe ocombe commented Jan 30, 2018

Apparently the tests for the date pipe fail on chrome mobile 63. I'll investigate, but in the mean time this PR should unblock master.

Tracking the issue here: #21907

@ocombe ocombe added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jan 30, 2018
@ocombe ocombe requested a review from vicb January 30, 2018 17:52
@ocombe ocombe force-pushed the fix/#21655-test-date-timezone branch from 4269f89 to 340c8c2 Compare January 30, 2018 18:01
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 30, 2018
@vicb
Copy link
Contributor

vicb commented Jan 30, 2018

blocked -> seems like the PR does not solve the SL issue

@vicb vicb removed the action: merge The PR is ready for merge by the caretaker label Jan 30, 2018
@ocombe ocombe force-pushed the fix/#21655-test-date-timezone branch from 340c8c2 to ec12f2e Compare January 30, 2018 18:37
@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed state: blocked labels Jan 30, 2018
@jasonaden jasonaden closed this in bb577c6 Jan 30, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants