test(common): disable deprecated date pipe tests on chrome mobile #21933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
action: review
ocombe
force-pushed
the
fix/#21655-test-date-timezone
branch
2 times, most recently
from
b86622d
to
0c7ff58
Compare
vicb
reviewed
Jan 31, 2018
| @@ -12,7 +12,10 @@ import {JitReflector} from '@angular/platform-browser-dynamic/src/compiler_refle | |||
| import {browserDetection} from '@angular/platform-browser/testing/src/browser_util'; | |||
|
|
|||
| { | |||
| xdescribe('DeprecatedDatePipe', () => { | |||
| // some tests are disabled on chrome mobile because of the following bug affecting the intl API | |||
There was a problem hiding this comment.
Can you please enclose the comment + test in a function and use this function so that we know why a test is disabled ?
function hasCromeBug796583(): boolean {
return ...;
}
if (!hasCromeBug796583 || ...) {
...
}
vicb
added
action: cleanup
|
Feel free to add the merge label once the requested change is implemented. |
ocombe
force-pushed
the
fix/#21655-test-date-timezone
branch
from
0c7ff58
to
45a6295
Compare
ocombe
force-pushed
the
fix/#21655-test-date-timezone
branch
from
45a6295
to
89da2c9
Compare
ocombe
removed
the
action: cleanup
vicb
approved these changes
Feb 2, 2018
mhevery
pushed a commit
that referenced
this pull request
Feb 7, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There's a bug in chrome mobile 63 with the intl API: https://bugs.chromium.org/p/chromium/issues/detail?id=796583
because of that, the deprecated date pipe tests are failing.
Issue Number: #21907
What is the new behavior?
Those tests are disabled on chrome mobile
Does this PR introduce a breaking change?