New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ivy): temp disable payload limit tests #21940
Conversation
@kara we discussed this with @IgorMinar and decided to disable the size tracking for render3 for now. Tha plan is to do it on symbol level. This is creating too much noise. Could you disable it? //cc @chuckjaz |
wait - this is not what we agreed on though. because you disabled it here, we no longer see the trend (see how the graph ends abruptly https://size.angular.io/hello_world__render3__rollup/master) What we agreed on is that we will no longer break the build when the size changes. This was supposed to be done by removing these lines of code: angular/integration/_payload-limits.json Lines 18 to 40 in b58c352
Can we please roll back this change and update the _payload-limits.json as I suggested? |
Apologies! Clearly misunderstood your meaning. |
No worries. I asked Misko to fix this unless you want to do it. Please sync
up with Misko.
…On Wed, Feb 7, 2018 at 2:06 PM Kara ***@***.***> wrote:
Apologies! Clearly misunderstood your meaning.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#21940 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6FK9f7b0NC9Tl1lVEyINQidX15stks5tSh5OgaJpZM4R0eji>
.
|
8682348
to
6ceefc6
Compare
Given that we have a new way of tracking the payload, is this still needed? |
The new way doesn't show trend. Alex has requested that feature but it's
going to take a while. In this meantime all we have are comments on various
PRs that don't show us the trend.
…On Wed, Feb 7, 2018, 8:38 PM Miško Hevery ***@***.***> wrote:
Given that we have a new way of tracking the payload, is this still needed?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#21940 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANM6LWvcrcwnlSvLY7ZnoeyjGPNr15iks5tSnozgaJpZM4R0eji>
.
|
@IgorMinar now that we buildsize bot is your comment still relevant? |
yes. please read #21940 (comment) |
Hi @kara! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
Hi @kara! This PR has merge conflicts due to recent upstream merges. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Update payload size for ivy