Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ivy): misc refactoring #22001

Closed
wants to merge 1 commit into from
Closed

refactor(ivy): misc refactoring #22001

wants to merge 1 commit into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 2, 2018

goal: make the code easier to understand.

@vicb vicb added action: review The PR is still awaiting reviews from at least one requested reviewer refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release comp: ivy labels Feb 2, 2018
@mary-poppins
Copy link

You can preview 3dc2e27 at https://pr22001-3dc2e27.ngbuilds.io/.

Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer shorter name child over firstChild the rest looks good.

@vicb vicb added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Feb 5, 2018
@mary-poppins
Copy link

You can preview 2bcfa6d at https://pr22001-2bcfa6d.ngbuilds.io/.

@alxhub alxhub closed this in 5df626b Feb 5, 2018
@vicb vicb deleted the 0202-ref branch February 5, 2018 22:04
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes refactoring Issue that involves refactoring or code-cleanup target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants