docs: fix reactive forms language and example #22094

kapunahelewong · 2018-02-08T16:30:14Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2209 and #21968

What is the new behavior?

change to not call ngOnChanges directly, changes button from type reset, and reworks text to reflect these changes. Also clarifies error map info.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

buildsize · 2018-02-08T16:35:30Z

This change will decrease the build size from 10.83 KB to 8.04 KB, a decrease of 2.79 KB (35%)

File name	Previous Size	New Size	Change
bundle.min.js	8.06 KB	8.04 KB	-23 bytes (0%)
bundle.min.js.brotli	2.77 KB	[deleted]

mary-poppins · 2018-02-21T21:49:18Z

You can preview 2b04361 at https://pr22094-2b04361.ngbuilds.io/.

mary-poppins · 2018-02-24T18:06:45Z

You can preview 285ec66 at https://pr22094-285ec66.ngbuilds.io/.

mary-poppins · 2018-02-26T23:52:29Z

You can preview d4d2a09 at https://pr22094-d4d2a09.ngbuilds.io/.

mary-poppins · 2018-02-27T15:57:01Z

You can preview c777faf at https://pr22094-c777faf.ngbuilds.io/.

mary-poppins · 2018-02-27T18:56:37Z

You can preview 01bba32 at https://pr22094-01bba32.ngbuilds.io/.

mary-poppins · 2018-02-28T19:42:14Z

You can preview c16fa3d at https://pr22094-c16fa3d.ngbuilds.io/.

mary-poppins · 2018-02-28T21:28:11Z

You can preview 6310262 at https://pr22094-6310262.ngbuilds.io/.

mary-poppins · 2018-03-01T15:54:02Z

You can preview a17ae91 at https://pr22094-a17ae91.ngbuilds.io/.

mary-poppins · 2018-03-06T15:27:56Z

You can preview 61e0505 at https://pr22094-61e0505.ngbuilds.io/.

kara

Small nits

kara · 2018-03-07T20:53:07Z

aio/content/guide/reactive-forms.md

@@ -106,15 +106,15 @@ You must wrap your test block in `async()` or `fakeAsync()` to
 avoid looking for values in the form that aren't there yet.
 With reactive forms, everything is available when you expect it to be.

-### Which is better, reactive or template-driven?
+### Choosing reactive or template-driven forms


Like this language better, thanks

kara · 2018-03-07T21:00:04Z

aio/content/guide/reactive-forms.md


+## Essential form classes
+This guide uses four fundamental classes to build a reactive forms:


Typo: a reactive forms -> a reactive form

Great catch. Fixed!

kara · 2018-03-07T21:01:13Z

aio/content/guide/reactive-forms.md

 `FormControl`, `FormGroup`, and `FormArray`.
-It provides their common behaviors and properties, some of which are _observable_.
+It provides their common behaviors and properties,
+some of which are observable.


I'm not sure I understand some of which are observable. All of them are observable, no? Maybe it's supposed to be some of them are observables? I think it should be removed bc it's confusing.

Agreed. Removed that phrase.

kara · 2018-03-07T21:01:46Z

aio/content/guide/reactive-forms.md

-It corresponds to an HTML form control such as an input box or selector.
+      [`FormControl`](api/forms/FormControl "API Reference: FormControl")
+tracks the value and validity status of an individual form control.
+It corresponds to an HTML form control such as an `<input>` or `<selector>`.


You mean <select> here, I think?

Ha! Yes, thank you for catching that. Fixed. :)

kara · 2018-03-07T21:09:49Z

aio/content/examples/reactive-forms/src/app/hero-detail/hero-detail.component.ts

+    this.rebuildForm();
+  }
+
+  rebuildForm() {
    this.heroForm.reset({
      name: this.hero.name
    });


I can't comment directly on it, but looks like there is still an ngOnChanges reference in onSubmit below (line 76)

Ohhhh I see. Yes, changed to rebuildForm().

…es (angular#22094) PR Close angular#22094

angular-automatic-lock-bot · 2019-09-15T04:22:50Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Feb 8, 2018

mhevery added the comp: docs label Feb 13, 2018

kapunahelewong force-pushed the reactive-forms-fix branch from bf4d403 to 2b04361 Compare February 21, 2018 21:39

kapunahelewong added aio: preview target: patch This PR is targeted for the next patch release labels Feb 21, 2018

kapunahelewong force-pushed the reactive-forms-fix branch from 2b04361 to 285ec66 Compare February 24, 2018 17:55

kapunahelewong force-pushed the reactive-forms-fix branch from 285ec66 to d4d2a09 Compare February 26, 2018 23:44

kapunahelewong force-pushed the reactive-forms-fix branch from d4d2a09 to c777faf Compare February 27, 2018 15:47

kapunahelewong changed the title ~~[WIP]docs: fix reactive forms language and example~~ docs: fix reactive forms language and example Feb 27, 2018

kapunahelewong force-pushed the reactive-forms-fix branch from c777faf to 01bba32 Compare February 27, 2018 18:48

kapunahelewong force-pushed the reactive-forms-fix branch from 01bba32 to c16fa3d Compare February 28, 2018 19:13

kapunahelewong force-pushed the reactive-forms-fix branch from c16fa3d to 6310262 Compare February 28, 2018 21:15

kapunahelewong force-pushed the reactive-forms-fix branch from 6310262 to a17ae91 Compare March 1, 2018 15:44

kapunahelewong assigned kara Mar 1, 2018

kapunahelewong requested a review from jenniferfell March 1, 2018 16:28

kapunahelewong unassigned kara Mar 1, 2018

kapunahelewong requested a review from kara March 1, 2018 16:28

kapunahelewong force-pushed the reactive-forms-fix branch from a17ae91 to 61e0505 Compare March 6, 2018 15:20

kara reviewed Mar 7, 2018

View reviewed changes

docs: refactor revert() and call to lifecylce hook, edit doc to changes

2692dfa

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018

docs: refactor revert() and call to lifecylce hook, edit doc to chang…

ae50e77

…es (angular#22094) PR Close angular#22094

jenniferfell mentioned this pull request Jun 6, 2018

[DOCS] Misleading docs : reactive-forms#revert-cancel-changes #21968

Closed

8 tasks

kapunahelewong deleted the reactive-forms-fix branch June 7, 2019 14:20

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: fix reactive forms language and example #22094

docs: fix reactive forms language and example #22094

kapunahelewong commented Feb 8, 2018 •

edited

buildsize bot commented Feb 8, 2018 •

edited

mary-poppins commented Feb 21, 2018

mary-poppins commented Feb 24, 2018

mary-poppins commented Feb 26, 2018

mary-poppins commented Feb 27, 2018

mary-poppins commented Feb 27, 2018

mary-poppins commented Feb 28, 2018

mary-poppins commented Feb 28, 2018

mary-poppins commented Mar 1, 2018

mary-poppins commented Mar 6, 2018

kara left a comment

kara Mar 7, 2018

kapunahelewong Mar 7, 2018

kara Mar 7, 2018

kapunahelewong Mar 7, 2018 •

edited

kara Mar 7, 2018

kapunahelewong Mar 7, 2018

kara Mar 7, 2018

kapunahelewong Mar 7, 2018

kara Mar 7, 2018

kapunahelewong Mar 7, 2018

angular-automatic-lock-bot bot commented Sep 15, 2019


		## Essential form classes
		This guide uses four fundamental classes to build a reactive forms:

docs: fix reactive forms language and example #22094

docs: fix reactive forms language and example #22094

Conversation

kapunahelewong commented Feb 8, 2018 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

buildsize bot commented Feb 8, 2018 • edited

mary-poppins commented Feb 21, 2018

mary-poppins commented Feb 24, 2018

mary-poppins commented Feb 26, 2018

mary-poppins commented Feb 27, 2018

mary-poppins commented Feb 27, 2018

mary-poppins commented Feb 28, 2018

mary-poppins commented Feb 28, 2018

mary-poppins commented Mar 1, 2018

mary-poppins commented Mar 6, 2018

kara left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kapunahelewong Mar 7, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

angular-automatic-lock-bot bot commented Sep 15, 2019

kapunahelewong commented Feb 8, 2018 •

edited

buildsize bot commented Feb 8, 2018 •

edited

kapunahelewong Mar 7, 2018 •

edited