ci: update ngbot config file #22173
Closed
ci: update ngbot config file #22173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocombe
added
target: patch
IgorMinar
approved these changes
Feb 13, 2018
| @@ -50,13 +50,15 @@ merge: | |||
| noConflict: true | |||
| # list of labels that a PR needs to have, checked with a regexp (e.g. "PR target:" will work for the label "PR target: master") | |||
| requiredLabels: | |||
| - "PR target:" | |||
| - "PR target: *" | |||
There was a problem hiding this comment.
I hope these are globs and not some custom patterns/matching language.
There was a problem hiding this comment.
The comment above says they are used as RegExps. I hope that's not true either 😃
IgorMinar
added
action: merge
|
It was using regexps previously but I've just updated the code to use globs
instead since it makes more sense, I'll update the comments
Le lun. 12 févr. 2018 23:20, George Kalpakas <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In .github/angular-robot.yml
<#22173 (comment)>:
> @@ -50,13 +50,15 @@ merge:
noConflict: true
# list of labels that a PR needs to have, checked with a regexp (e.g. "PR target:" will work for the label "PR target: master")
requiredLabels:
- - "PR target:"
+ - "PR target: *"
The comment above says they are used as RegExps. I hope that's not true
either 😃
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22173 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAQMos7roMCuqKT1-XuYcHiwVUUvrT2Fks5tUTexgaJpZM4SCnuJ>
.
|
mhevery
pushed a commit
that referenced
this pull request
Feb 13, 2018
jbogarthyde
pushed a commit
to jbogarthyde/angular
that referenced
this pull request
Feb 23, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Some
typelabels aren't considered as triaged.Some PR state/action aren't blocking the merge when they should.
Issue Number: #22053
What is the new behavior?
Type refactor and type RFC/Discussion/question are now considered as triaged.
The labels PR action review and PR state blocked are now forbidden labels that will prevent the merge status to go green.
I've also slightly updated some regexp to be compliant with minimatch instead of just simple regexp. It should be easier to understand like that.
Does this PR introduce a breaking change?