New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(aio): updated padding-right to h3 in _heading-anchors.scss #22431
Conversation
@@ -11,6 +11,7 @@ | |||
|
|||
h3 { | |||
margin: 8px 0 0; | |||
padding-left: 34px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned by @petebacondarwin in #22407 (comment), the styles for <h3>
are fine.
You should instead change the .heading-anchor
styles in _heading-anchors.scss. More specifically, I think you should change this line:
padding-right: 24px;
padding-right: 64px;
(For reference, this was accidentally broken in e3e7044.)
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents. fixes: #22407
I've applied your fix @gkalpak, please let me know if theres anything else I can do. See below for some updated screenshots: |
You can preview 5ee251e at https://pr22431-5ee251e.ngbuilds.io/. |
You can preview 8a429a6 at https://pr22431-8a429a6.ngbuilds.io/. |
After looking further into other documentation with @haoRchen, we stumbled across another section in his patch mentioned above that has a formatting issue here: It looks like the padding will need to be adjusted here also! |
2dbbeaa addresses @SeanPrashad 's comment. |
You can preview 2dbbeaa at https://pr22431-2dbbeaa.ngbuilds.io/. |
…chors.scss The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents. fixes: #22407
You can preview cde3dc1 at https://pr22431-cde3dc1.ngbuilds.io/. |
You can preview 6647bae at https://pr22431-6647bae.ngbuilds.io/. |
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents. fixes: angular#22407 PR Close angular#22431
…chors.scss (angular#22431) The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents. fixes: angular#22407 PR Close angular#22431
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents. fixes: angular#22407 PR Close angular#22431
…chors.scss (angular#22431) The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents. fixes: angular#22407 PR Close angular#22431
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents.
fixes: #22407
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 22407
What is the new behavior?
Does this PR introduce a breaking change?
Other information