Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(aio): updated padding-right to h3 in _heading-anchors.scss #22431

Closed
wants to merge 2 commits into from
Closed

style(aio): updated padding-right to h3 in _heading-anchors.scss #22431

wants to merge 2 commits into from

Conversation

haoRchen
Copy link
Contributor

The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents.

fixes: #22407

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

issue

Issue Number: 22407

What is the new behavior?

fixed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@haoRchen
Copy link
Contributor Author

In addition, I noticed that the header is not being aligned properly in mobile/responsive views. See below:

mobile view error

Please advise.

@gkalpak gkalpak added state: WIP comp: aio aio: preview target: patch This PR is targeted for the next patch release type: bug/fix labels Feb 25, 2018
@@ -11,6 +11,7 @@

h3 {
margin: 8px 0 0;
padding-left: 34px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by @petebacondarwin in #22407 (comment), the styles for <h3> are fine.

You should instead change the .heading-anchor styles in _heading-anchors.scss. More specifically, I think you should change this line:

padding-right: 24px;
padding-right: 64px;

(For reference, this was accidentally broken in e3e7044.)

@petebacondarwin petebacondarwin added this to WIP in docs-infra Feb 25, 2018
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents.

fixes: #22407
@haoRchen
Copy link
Contributor Author

I've applied your fix @gkalpak, please let me know if theres anything else I can do. See below for some updated screenshots:
fix
side fix

@mary-poppins
Copy link

You can preview 5ee251e at https://pr22431-5ee251e.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8a429a6 at https://pr22431-8a429a6.ngbuilds.io/.

@seanprashad
Copy link

seanprashad commented Feb 26, 2018

After looking further into other documentation with @haoRchen, we stumbled across another section in his patch mentioned above that has a formatting issue here:

post-dev-suggestion-fix

It looks like the padding will need to be adjusted here also!

@haoRchen
Copy link
Contributor Author

2dbbeaa addresses @SeanPrashad 's comment.

After fix screenshot:
fix for take a break

@mary-poppins
Copy link

You can preview 2dbbeaa at https://pr22431-2dbbeaa.ngbuilds.io/.

@haoRchen haoRchen changed the title style(aio): added padding-left to h3 in _subsection.scss style(aio): updated padding-right to h3 in _heading-anchors.scss Feb 26, 2018
…chors.scss

The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents.

fixes: #22407
@mary-poppins
Copy link

You can preview cde3dc1 at https://pr22431-cde3dc1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6647bae at https://pr22431-6647bae.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed state: WIP labels Feb 26, 2018
@ngbot
Copy link

ngbot bot commented Feb 26, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure conflicts with base branch "master"
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Feb 26, 2018
alexeagle pushed a commit that referenced this pull request Feb 27, 2018
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents.

fixes: #22407

PR Close #22431
alexeagle pushed a commit that referenced this pull request Feb 27, 2018
…chors.scss (#22431)

The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents.

fixes: #22407

PR Close #22431
@alexeagle alexeagle closed this in 7e4c13f Feb 27, 2018
alexeagle pushed a commit that referenced this pull request Feb 27, 2018
…chors.scss (#22431)

The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents.

fixes: #22407

PR Close #22431
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents.

fixes: angular#22407

PR Close angular#22431
smdunn pushed a commit to smdunn/angular that referenced this pull request Feb 28, 2018
…chors.scss (angular#22431)

The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents.

fixes: angular#22407

PR Close angular#22431
@petebacondarwin petebacondarwin removed this from WIP in docs-infra Mar 1, 2018
@haoRchen haoRchen deleted the issue-22407 branch March 4, 2018 16:01
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
The h3 element is overflowing over its surrounding div element. Modified padding-left to align consistently with the remainder of div contents.

fixes: angular#22407

PR Close angular#22431
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
…chors.scss (angular#22431)

The h3 element is overflowing over its surrounding div element. Modified padding-right to align consistently with the remainder of div contents.

fixes: angular#22407

PR Close angular#22431
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs - h3 heading misaligned inside div
5 participants