Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix table in comparing observables guide #22485

Closed
wants to merge 1 commit into from

Conversation

ro-savage
Copy link
Contributor

Fix table in comparing-observables.md that was incorrectly formatted.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Table columns are off by one.

Issue Number: N/A

What is the new behavior?

Table formatted correctly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@ngbot
Copy link

ngbot bot commented Mar 7, 2018

Hi @ro-savage! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jenniferfell jenniferfell added the state: community Someone from the Angular community is working on this issue or submitted this PR label Jul 23, 2018
@brandonroberts brandonroberts added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews aio: preview target: patch This PR is targeted for the next patch release docsarea: observables labels Jul 31, 2018
@mary-poppins
Copy link

You can preview 9e492ec at https://pr22485-9e492ec.ngbuilds.io/.

Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the git commit message to docs: fix table formatting in comparing observables guide

@brandonroberts brandonroberts self-assigned this Jul 31, 2018
@brandonroberts brandonroberts removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 2, 2018
@mary-poppins
Copy link

You can preview 95151a1 at https://pr22485-95151a1.ngbuilds.io/.

@brandonroberts brandonroberts changed the title Fix table in comparing-observables.md docs: fix table in comparing observables guide Aug 6, 2018
@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Aug 6, 2018
@kara kara closed this in b8887dd Aug 6, 2018
kara pushed a commit that referenced this pull request Aug 6, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants